php-in-php: drop always-on LibcExtern/Module strrchr after StrrchrJitHelper (#31403/#31374 shape)

[PurHur]

Category

php-in-php · runtime-shrink (#1492, peer #31403 / #31374 / #30530)

Problem

User-script strrchr() already routes through StrrchrJitHelper + StringStrrchr (__phpc_jit_strrchr, #15406). Always-on LibcExtern + Module::jitInit still register libc strrchr for every compile — same dead always-on surface #31403 removed for stat/access/lstat.

Path	Today	Target
User-script AOT strrchr()	StrrchrJitHelper / VmString::strrchr (already)	unchanged
LibcExtern	always-on strrchr	drop row
Module::jitInit	always-on try/add	drop; comment #31403 peer
NestedJIT JitTempnamKernel	ensureLibc already declares strrchr module-locally	unchanged
ReflectionSetup::shortNameFromCstr	lookupFunction relies on always-on	ensureLibcStrrchr module-local

php-src reference

• php/php-src ext/standard/string.c — PHP_FUNCTION(strrchr) (semantics stay in PHP helpers; libc is thin ABI only for NestedJIT path basename)

PHP implementation target

• lib/JIT/LibcExtern.php — drop strrchr row; cite this issue
• ext/standard/Module.php — drop always-on decl
• lib/JIT/Builtin/ReflectionSetup.php — ensureLibcStrrchr before shortNameFromCstr lookup
• test/unit/LibcExternDeadDeclsRuntimeShrinkTest.php + ModuleAlwaysOnFsDeclsRuntimeShrinkTest.php — guard the drop

Repro

./script/phpunit.sh --filter LibcExternDeadDeclsRuntimeShrinkTest
./script/phpunit.sh --filter ModuleAlwaysOnFsDeclsRuntimeShrinkTest

Done when

• strrchr absent from LibcExtern specs and Module::jitInit always-on decls
• ReflectionSetup declares strrchr module-locally; JitTempnamKernel keep working
• Shrink unit tests green
• PR body cites LOC removed from always-on surface

Refs #1492, #31403, #31374, #30530, #15406

[PurHur]

claim: PHP Runtime → PHP — starting this run

Dropping always-on LibcExtern/Module strrchr (peer #31403). Branch agent/runtime-php-strrchr-31458.

[PurHur]

Merged via #31459

Verification: ./script/phpunit.sh --filter 'StrrchrRuntimeShrinkTest|LibcExternDeadDeclsRuntimeShrinkTest|ModuleAlwaysOnFsDeclsRuntimeShrinkTest' → OK (11 tests, 109 assertions).

C surface removed: LibcExtern strrchr row + Module always-on try/add (~9 LOC). NestedJIT keeps module-local decls in JitTempnamKernel + ReflectionSetup::ensureLibcStrrchr.