Regression: get_browser(..., null) $return_array under strict_types DEP+false — Zend TypeError (ext/standard/browscap.c)

[PurHur]

Category

stdlib · php-src-strict

Problem

Under declare(strict_types=1), get_browser($user_agent = null, $return_array = null) must TypeError on bool $return_array. Zend accepts null $user_agent (optional) and TypeErrors on null $return_array. VM soft-deprecates (message even cites parameter #1 ($return_array)), warns that browscap is unset, and returns false.

Repro	Zend 8.2.32 (2026-08-15)	VM (2026-08-15)
declare(strict_types=1); get_browser(null, null)	TypeError: get_browser(): Argument #2 ($return_array) must be of type bool, null given	E_DEPRECATED (param #1 ($return_array)) + browscap warning + false

php-src reference

• php/php-src ext/standard/browscap.c — PHP_FUNCTION(get_browser) / php_get_browser
• php/php-src ext/standard/basic_functions.stub.php — get_browser(?string $user_agent = null, bool $return_array = false)

PHP implementation target

• ext/standard/get_browser.php — VmMath::parseBoolBuiltinArg for arg Php stdlib specs implementation #2 must TypeError under strict_types; fix deprecation index/name if soft path remains
• lib/JIT/Builtin/GetBrowserRuntime.php / GetBrowser JIT helper — same behavior
• Reflection/browser_name vs user_agent remains Regression: get_browser Reflection names browser_name — Zend user_agent; named args rejected (ext/standard/basic_functions.stub.php) #23382 (out of scope unless free)

Repro

./script/docker-exec.sh -- bash -lc 'php -r '\''declare(strict_types=1); try { var_export(get_browser(null, null)); } catch (Throwable $e) { echo get_class($e), ": ", $e->getMessage(), "\n"; }'\'''
./script/docker-exec.sh -- bash -lc 'php bin/vm.php -r '\''declare(strict_types=1); try { var_export(get_browser(null, null)); } catch (Throwable $e) { echo get_class($e), ": ", $e->getMessage(), "\n"; }'\'''

Done when

• VM/JIT/AOT: null $return_array under strict_types → Zend TypeError (no browscap warning / false)
• Null $user_agent alone still allowed (Zend optional)
• Compliance .phpt under test/compliance/cases/stdlib/
• php-src-strict; no php-compiler-strict shortcut

[PurHur]

claim: PHP Compiler STD Lib — starting this run

[PurHur]

Merged in #31342.

Verification

• VM: get_browser(null, null) under strict_types → TypeError: … Argument #2 ($return_array) …
• JIT + AOT: test/repro/issue_31289_get_browser_null_return_array.php (AOT uses non-null UA; literal null UA + 2nd arg is a pre-existing thin-AOT crash outside this builtin)
• ./script/phpunit.sh --filter GetBrowserNullReturnArrayStrict31289 OK
• ./script/phpunit.sh --filter get_browser_null_return_array_strict test/aot/AotTest.php OK

php-src: ext/standard/browscap.c / stub bool $return_array. PHP: ext/standard/get_browser.php.