Repository navigation
Language: final plain properties isFinal=0 + child override accepted under PROFILE=8.4 (re-#27315, Zend/zend_inheritance.c) #27818
Description
Category
Language · php-src-strict · PHP 8.4 final properties
Problem
Under PHP_COMPILER_PROFILE=8.4, plain final public properties still report ReflectionProperty::isFinal() === false, and a child class may redeclare the same property. Zend/php-src 8.4+ keeps post-construct writes allowed (inheritance-only final) but isFinal() is true and child redeclaration is a compile fatal. Previously closed as fixed in #27315 / PR #27336 — regressed on master (verified 2026-08-05).
| Repro | Zend 8.4+ | VM/JIT PROFILE=8.4 (2026-08-05) |
|---|---|---|
final public string $x; write after construct |
write OK | write OK (correct) |
ReflectionProperty::isFinal() |
true / 1 |
false / 0 |
class B extends A { public string $x = ... } |
compile fatal | accepted (override_ok) |
php-src reference
- php/php-src
Zend/zend_compile.c— final property compile flags - php/php-src
Zend/zend_inheritance.c— property inheritance / override rejection - php/php-src
ext/reflection/php_reflection.c—ReflectionProperty::isFinal()
PHP implementation target
lib/property / class compile + inheritance checks — set final flag on plain properties; reject child redeclarationext/reflection/ ReflectionProperty path — surfaceisFinal()from the flag (not a C-only shortcut)- Reuse committed repro
test/repro/maintainer_gap_final_plain_property_84.php(+ add override fatal case)
Repro
./script/docker-exec.sh -- bash -lc 'PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/maintainer_gap_final_plain_property_84.php'
# expect: wrote / isFinal=1
# actual: wrote / isFinal=0
./script/docker-exec.sh -- bash -lc 'PHP_COMPILER_PROFILE=8.4 php bin/vm.php -r "
class A { final public string \$x = \"a\"; }
class B extends A { public string \$x = \"c\"; }
echo \"bad\n\";
"'
# expect: Fatal error (cannot override final property)
# actual: prints badDone when
- PROFILE=8.4 VM/JIT/AOT:
isFinal=1on committed repro; post-construct write still succeeds (Zend inheritance-only semantics) - Child redeclaration of a final plain property is a compile fatal matching Zend
- Compliance/unit guard under
test/compliance/ortest/unit/for isFinal + override - php-src-strict; no php-compiler-strict shortcut
Activity
PurHur commentedon Aug 5, 2026
claim: worker-lane-C — starting this run
Pillar snapshot (pre-claim):
bootstrap-inventory.php --check: doc drift (construct flags / ScopeBuiltinJitHelper) — regenerate needed on tiprelease-readiness --json: still running at claim timeRepro target: PROFILE=8.4 final plain property
isFinal+ child override fatal (re-#27315).PurHur commentedon Aug 5, 2026
claim: worker-lane-C — continuing this run (prior claim had no PR/branch; taking implementation)
Pillar snapshot:
Language: AOT trait-imported final props keep isFinal + override fatal (
PurHur commentedon Aug 5, 2026
merged: #27861 (
435f54089c)Verification (Docker
./script/docker-exec.sh):wrote/isFinal=1(already green on tip; locked)isFinal=1; child override AOT build exit 255Cannot override final property A::$xvendor/bin/phpunit --filter FinalPropertyOverrideCheckTestOK (21)vendor/bin/phpunit --filter final_plain_property_trait_isfinal_84OKRoot cause:
inheritTraitInstancePropertiescopied readonly but notZEND_ACC_FINALintoObject_::finalPropertyNames;FinalPropertyOverrideCheckignoredTraitUse.