Regression: AOT asort()/ksort() compile fails — Module verify arity (ext/standard/array.c)

[PurHur]

Category

bug · php-src-strict · stdlib · user-script AOT · pillar 4

Problem

asort / ksort match Zend on VM and JIT, but thin AOT fails module verification with incorrect call arity. Sibling of #27227 (krsort/arsort same Module.php:180 failure).

Probed 2026-08-03 @ 3cf38597b.

Repro	Zend / VM / JIT	AOT (2026-08-03)
$a=['b'=>2,'a'=>1,'c'=>3]; asort($a); echo keys|values	a,b,c|1,2,3	BUILD FAIL Module verification failed due to Incorrect number of arguments passed to called function!
$a=…; ksort($a); …	a,b,c|1,2,3	same BUILD FAIL

Null-array probes also fail at compile with the same verify error (cannot reach TypeError path until build is fixed).

php-src reference

• php/php-src ext/standard/array.c — PHP_FUNCTION(asort) / PHP_FUNCTION(ksort)
• Stub: php/php-src ext/standard/array.stub.php

PHP implementation target

• KeySort / ValueSort NestedJIT helpers under ext/standard + lib/JIT (same arity mismatch class as Regression: AOT krsort()/arsort() compile fails — Module verify arity (ext/standard/array.c) #27227 / re-php-in-php: route standalone AOT ksort/krsort through KeySortJitHelper PHP (#12770 completion) #13050 / php-in-php: route standalone AOT asort/arsort through ValueSortJitHelper PHP (#12771 completion) #13053)
• Fix callee signature mismatch that only surfaces in thin standalone AOT verify
• Prefer PHP-in-PHP; no new runtime/*.c logic

Repro

./script/docker-exec.sh -- bash -lc '
cat > /tmp/aot_asort.php <<'"'"'PHP'"'"'
<?php
$a = ["b" => 2, "a" => 1, "c" => 3];
asort($a);
echo implode(",", array_keys($a)), "|", implode(",", array_values($a)), "\n";
PHP
php bin/vm.php /tmp/aot_asort.php
php bin/jit.php /tmp/aot_asort.php
php bin/compile.php -o /tmp/aot_asort /tmp/aot_asort.php
/tmp/aot_asort
'

Done when

• phpc build / bin/compile.php succeeds for asort and ksort key/value echo repros
• Native binary stdout matches Zend / VM / JIT
• Compliance or test/repro/ guard
• php-src-strict; no php-compiler-strict shortcut

Refs #27227, #10533

[PurHur]

claim: PHP Compiler STD Lib — starting this run

[PurHur]

Run snapshot before fix work:

• bootstrap-selfhost-link: stalled after stale native driver freshness fallback; stopped only this workspace container.
• bootstrap-inventory --check: local docs/bootstrap-inventory.md drift (ext/sodium/SodiumPadJitHelper.php path addition).
• release-readiness --json: user_release_ready=no; first failing gate helper-runtime-prelink core fingerprint mismatch (committed b61cb91617d413c31a57 vs live 72a83eeac48e8a462309); also cold-build timeout, spine coverage miss ext/sodium/SodiumPadJitHelper.php, north-star5-fast fail.

[PurHur]

Progress update:

• Reproduced original failure: AOT compile died in module verify with incorrect helper call arity for ValueSortJitHelper::asortByValue/arsortByValue.
• Local patch in lib/JIT/Builtin/ValueSortRuntime.php + lib/JIT/Builtin/KeySortRuntime.php now routes regular sort bridges through explicit (hashtable, flags) ABI params, with locale bridges still one-arg.
• Result: module-verify arity failure no longer reproduces on successful compile runs.

Current blocker:

• AOT compile/run is now intermittent and unstable on this repro (phpc: fatal signal (segfault) after c:main_before_php, plus occasional native abort / empty "|" output). This prevents calling the issue fixed yet.
• Next step is to pin down the intermittent crash/wrong-output path (likely bridge/helper ABI coercion under NestedJIT helper linking) before PR.

[PurHur]

claim: PHP Compiler STD Lib — starting this run

Gate snapshot (before work):

• php script/bootstrap-inventory.php --check → OK 7113/7113
• Continuing Regression: AOT asort()/ksort() compile fails — Module verify arity (ext/standard/array.c) #27513 (claim >48h old; prior WIP noted intermittent AOT segfault after arity fix)
• Next: reproduce asort/ksort AOT on current master, finish arity/ABI fix, verify native stdout vs Zend/VM

[PurHur]

Merged via #28073

Verification (this workspace, Docker):

• Zend / VM / AOT repro test/repro/issue_27513_aot_asort_ksort.php → a,b,c|1,2,3 ×2
• Native binary 10× match (no segfault / wrong output)
• AsortKsortAot27513Test OK (27 assertions); AotTest asort + ksort_assoc OK

Behavior was already green after #27863 (HashTable LLVM); this PR adds the missing AOT/repro guard from the Done-when checklist.