Language: PHP 8 attributes reflection JIT/AOT (phase 2, post-#1354 VM)

[PurHur]

Category

language

Problem

#1354 ✅ and #1936 ✅ delivered VM v1: attributes parse, compile-time metadata on TYPE_DECLARE_CLASS / TYPE_DECLARE_METHOD, and read-only reflection (ReflectionClass::getAttributes(), ReflectionAttribute::getName()).

docs/capabilities-syntax.md still marks attributes as JIT/AOT deferred. Native bin/jit.php / phpc build binaries used in self-host must expose the same metadata as VM or reflection returns empty arrays / stubs.

php-src reference

• Zend/zend_compile.c — zend_compile_attributes, attachment to op_array / class_entry
• Zend/zend_reflection.c — zim_ReflectionClass_getAttributes, ReflectionAttribute object creation
• ext/reflection/php_reflection.c

Repro (today)

Save as test/compliance/cases/attribute_reflection_probe.php (or run inline):

<?php
#[\Attribute]
class Route {
    public function __construct(public string $path) {}
}

#[Route('/home')]
class Home {}

$r = new ReflectionClass(Home::class);
$attrs = $r->getAttributes();
echo count($attrs), "\n";
echo $attrs[0]->getName(), "\n";

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php -r "/* paste */"   # Zend: 1, Route
php bin/vm.php test/compliance/cases/attribute_reflection_probe.php 2>/dev/null || php bin/vm.php -r "..." 
php bin/jit.php -r "/* same */" 2>&1 | head -5
'

Expected Zend: 1 and Route (or fully qualified name). Gap: compare VM vs JIT vs AOT output; file fails if JIT/AOT prints 0 or fatals.

Scope (this repo)

Layer	Files	v1 target
Compiler	lib/Compiler.php	Serialize attribute class names + literal args into IR metadata
VM	lib/VM.php, lib/VM/BuiltinClasses.php	Already partial — extend if gaps found
JIT	lib/JIT.php	Emit const attribute tables into VMContext for reflection
AOT	lib/AOT/	Link metadata section; bootstrap-readable
Tests	test/compliance/cases/attribute_reflection_*.phpt	VM + @group llvm JIT

Out of scope (v1)

• ReflectionAttribute::newInstance() with arbitrary constructors
• Repeatable / parameter / property attributes
• Attributes on closures (Language: Closures and anonymous functions #72)

Done when

• VM compliance PHPT: getAttributes() count + getName() match Zend for class-level attribute
• JIT compliance PHPT green when LLVM present (same output as VM)
• AOT fixture executes reflection probe without empty attribute list
• php script/capability-syntax.php — attributes row JIT/AOT = yes (read path)
• php script/bootstrap-inventory.php --check clean or documented delta

Verification

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter attribute_reflection'
./script/ci-fast.sh --filter attribute_reflection

Dependencies

• Language: PHP 8 attributes (#[Attr] on classes, methods, properties) #1354 ✅ parse/compile
• Language: PHP 8 attributes — JIT/AOT reflection (phase 2 of #1354) #1936 ✅ VM reflection umbrella (implementation track)
• Language features wave 2: JIT/syntax gaps tracker (#1222–#1235) #1238 — wave-2 tracker (link only; no duplicate table)

Links

• docs/capabilities-syntax.md PHP 8 attributes row
• ROADMAP 🗺️ ROADMAP: Self-host + web-capable PHP subset (living) #78 Phase 1 Language

[PurHur]

claim: cursor-agent-lane-b — starting this run

[PurHur]

WIP on branch agent/issue-2467-attribute-reflection-jit-aot (PR incoming).

Done this run

• ReflectionRuntime: lazy MCJIT link of phpc_attr_registry.c + phpc_reflection_attr.c (clang bitcode + host libc includes); register linked symbols in functionScope (fixes phpc_attr_register_* lookup during __init__).
• C ABI: reflection side-table uses const void * object handles; JIT calls pass i8*.
• Fix ReflectionMethodGetAttributes: or_ → or (was breaking AOT compile for method attrs).
• Method attribute registration: fall back to classNameForId() when scope->className is empty during TYPE_DECLARE_METHOD.
• ReflectionAttribute external class + propertySlotFor(); store attribute names on instances via value-box property in getAttributes().

Verification

• VM: vendor/bin/phpunit --filter AttributeReflection ✅
• VM compliance: attribute_reflection_* ✅
• AOT: getAttributes() count ✅; ReflectionAttribute::getName() still returns empty (property write in native getAttributes handler not visible to method dispatch on array element — needs next pass)
• AOT method attrs: count still 0 (investigating emitRegisterMethod / phpc_reflect_set_method path)
• JIT MCJIT: harness bin/jit.php segfaults even on echo 42 on current Docker image (pre-existing; not introduced by this branch — verified by stashing changes)

Blocker for close

• AOT/native ReflectionAttribute::getName() must return stored name (AllowDynamicProperties / Deprecated).
• JIT compliance tests blocked on MCJIT segfault in harness (environment baseline).