php-in-php: TokenGetAll NestedJIT → JitVmHelperLink::ensureCompiled (#1492)

[PurHur]

Category

php-in-php · runtime-shrink (#1492, peer Highlight #24417 / StringIdate #24382)

Problem

lib/JIT/Builtin/TokenGetAll.php still hand-rolls NestedJitCompileScope::run + parseAndCompile + new JIT() for TokenGetAllJitHelper.php. Peer runtimes route helper compile through JitVmHelperLink::ensureCompiled for consistent user-script env clearing, insert-block restore, and helper-runtime cache.

php-src reference

• php/php-src ext/tokenizer/tokenizer.c — PHP_FUNCTION(token_get_all) (semantics unchanged; compile-path only)

PHP implementation target

• lib/JIT/Builtin/TokenGetAll.php — replace ensureJitHelperCompiled body with JitVmHelperLink::ensureCompiled + lookupCompiled; drop use PHPCompiler\JIT / NestedJitCompileScope
• test/unit/TokenGetAllRuntimeShrinkTest.php — guard JitVmHelperLink::ensureCompiled, no hand-rolled NestedJIT / parseAndCompile / new JIT(

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/unit/TokenGetAllRuntimeShrinkTest.php'
make bootstrap-selfhost-vm-driver-execute-probe

Done when

• TokenGetAll uses JitVmHelperLink::ensureCompiled only for helper compile
• Shrink unit test green
• make bootstrap-selfhost-vm-driver-execute-probe green
• PR body cites lines removed

Refs #1492, #3171, #24417

[PurHur]

claim: PHP Runtime → PHP — starting this run

Pillar 1 probe (this workspace, before claim):

• docker info: ok
• bootstrap-inventory --check (via release-readiness): OK 6616/6616
• release-readiness --json: user_release_ready: no
  • FAIL helper-runtime-prelink: STALE ext_standard_RangeIntJitHelper_php (refresh via emit-helper-runtime-object --prelink)
  • FAIL spine-coverage: missing lib/ExtensionRegistry.php (Release: generate the extension load list instead of hardcoding it (Phase 2.5) #24418 leftover)
  • FAIL north-star5-fast (downstream of spine)
  • ok: cold-build, root-readme-sync, vm-driver-probe
• First failing command: php script/check-helper-runtime-prelink.php --strict — RangeIntJitHelper stale
• Not fixing those trust leftovers in this run (owned by Release: generate the extension load list instead of hardcoding it (Phase 2.5) #24418 / RangeInt emit); TokenGetAll gate is shrink test + vm-driver-probe only.

Implementing NestedJIT → JitVmHelperLink::ensureCompiled (peer #24417).

[PurHur]

Merged #24428

Verification:

• TokenGetAllRuntimeShrinkTest OK 2/2
• TokenGetAllBuiltinTest OK 2/2 (VM + AOT lint)
• make bootstrap-selfhost-vm-driver-execute-probe OK

NestedJIT hand-roll removed from lib/JIT/Builtin/TokenGetAll.php; helper compile via JitVmHelperLink::ensureCompiled. No C runtime changes.