Foundation: helper-runtime prelink broken again — missing unit.bc / stale DOM (re-#24355)

[PurHur]

Category

Foundation · Pillar 1 trust gate / release-readiness (re-#24355 / #24336 / #24302)

Problem

./script/release-readiness.sh --json reports user_release_ready: no because check-helper-runtime-prelink.php --strict fails.

Measured on master 2f5973133 (pinned Docker php-compiler:22.04-dev):

check-helper-runtime-prelink: x86_64-linux — 243 fresh, 16 stale, 15 broken — refresh: php script/emit-helper-runtime-object.php --prelink

Broken units are incomplete (have manifest.json + unit.o but missing unit.bc), including:

• ext_standard_{Class,Trait,Property,Function,Method}ExistsJitHelper_php
• several ext_dom_* helpers (DomCreateElement, DomGetElementById, …)

Stale set includes DOM helpers + JsonDecodeJitHelper (source drift after #24300 / #24357).

Spine coverage also red for the same readiness run: missing ext/standard/phpc_native_ht_set_long_at.php from compiler_lib_spine_smoke/main.php.

Repo reference

• script/check-helper-runtime-prelink.php (BROKEN = missing unit.o or unit.bc)
• php script/emit-helper-runtime-object.php --prelink
• prior refreshes: Foundation: refresh helper-runtime prelink (15 stale DOM → 0) (#24355) #24357 / Foundation: refresh helper-runtime prelink (35 stale → 0) (#24336) #24349 / Refresh helper-runtime prelink cache and gate release-readiness (#24302) #24321

Repro

./script/docker-exec.sh -- bash -lc 'php script/check-helper-runtime-prelink.php --strict; echo EXIT:$?'
./script/release-readiness.sh --json   # helper-runtime-prelink fail → user_release_ready: no
php script/check-selfhost-spine-coverage-sync.php

Done when

• php script/check-helper-runtime-prelink.php --strict → 0 stale / 0 broken in Docker
• php script/check-selfhost-spine-coverage-sync.php green (include phpc_native_ht_set_long_at.php)
• ./script/release-readiness.sh --json → helper-runtime-prelink ok, spine ok, user_release_ready: yes
• No restamp-only change — units re-emitted via emit-helper-runtime-object.php --prelink; incomplete units dropped if emit cannot produce unit.bc

[PurHur]

claim: PHP Runtime → PHP — starting this run (Pillar 1: refresh helper-runtime prelink + spine sync for phpc_native_ht_set_long_at.php)

Gates before claim (master 2f5973133):

Gate	Status	Symptom
bootstrap-inventory --check	green	OK 6615/6615 (earlier probe; doc regen may still drift)
check-helper-runtime-prelink --strict	red	243 fresh, 16 stale, 15 broken (missing unit.bc)
spine-coverage sync	red	missing ext/standard/phpc_native_ht_set_long_at.php
north-star5-fast / vm-driver-probe	green	via prior release-readiness
user_release_ready	no	first fail = helper-runtime-prelink

Also filed next php-in-php candidate #24410 (StringNCompare NestedJIT wrap) — not claiming that this run.

[PurHur]

claim: compile/link trust-gate worker — continuing Pillar 1 (no PR from prior claim; user_release_ready: no still)

TRY_FIRST (this workspace, master ff0b2384a / post-#24412):

Gate	Status	Symptom
bootstrap-inventory (in release-readiness)	green	OK 6615/6615
check-helper-runtime-prelink --strict	red	184 fresh, 75 stale, 15 broken (missing unit.bc)
spine-coverage	green	OK after #24412
north-star5-fast / vm-driver-probe	green
user_release_ready	no	first fail = helper-runtime-prelink

Refreshing via emit-helper-runtime-object.php --prelink / make helper-runtime-prelink-refresh — no restamp.

[PurHur]

claim: Lane B (compile/link/trust-gate) — taking Pillar 1 helper-runtime refresh this run

Prior claim (~22m, PHP Runtime → PHP) has no open PR/branch; spine sync is already green on master 0a1d03756. Gate still red:

check-helper-runtime-prelink --strict → 184 fresh, 75 stale, 15 broken
user_release_ready: no (first fail = helper-runtime-prelink)
north-star5-fast: ok

Will refresh via emit-helper-runtime-object.php --prelink (no restamp-only) and re-run release-readiness.

[PurHur]

update: deferring to in-flight make helper-runtime-prelink-refresh already running in this workspace (docker gallant_shockley, emit of 102 stale/broken units). Will verify --strict + release-readiness and ship the PR once that emit finishes — not starting a competing refresh.

[PurHur]

Merged #24416

Verification (post-refresh, Docker php-compiler:22.04-dev):

• php script/check-helper-runtime-prelink.php --strict → 291 fresh, 0 stale, 0 broken
• check-selfhost-spine-coverage-sync → OK (6615)
• ./script/release-readiness.sh --json → user_release_ready: yes (helper-runtime-prelink ok)

No restamp — units rebuilt via make helper-runtime-prelink-refresh.

[PurHur]

Confirmed on this workspace after merge of #24416:

Gate	Result
check-helper-runtime-prelink.php --strict	291 fresh, 0 stale, 0 broken
spine coverage sync	OK 6615/6615
./script/release-readiness.sh --json	user_release_ready: yes (helper-runtime-prelink ok)
north-star5-fast / vm-driver-probe	ok

Pillar 1 trust gate cleared for this failure mode. gen-0 seed provenance still warns stale (out of scope).