php-in-php: StringCaseCompare NestedJIT → JitVmHelperLink::ensureCompiled (#1492)

[PurHur]

Category

php-in-php · runtime-shrink (#1492, peer #23832 / #15225)

Problem

lib/JIT/Builtin/StringCaseCompare.php still hand-rolls NestedJitCompileScope::run + parseAndCompile for CaseCompareJitHelper.php. Recent migrations (StringStrtotime #23832, ArrayDiffKey #23787) route through JitVmHelperLink::ensureCompiled, gaining helper-runtime cache hits and consistent user-script env clearing.

php-src reference

• php/php-src ext/standard/string.c — PHP_FUNCTION(strcasecmp|strncasecmp)

PHP implementation target

• lib/JIT/Builtin/StringCaseCompare.php — replace hand-rolled NestedJIT with JitVmHelperLink::ensureCompiled + lookupCompiled
• test/unit/StrcasecmpRuntimeShrinkTest.php — guard no hand-rolled NestedJIT remains

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
vendor/bin/phpunit test/unit/StrcasecmpRuntimeShrinkTest.php
'

Done when

• NestedJitCompileScope::run removed from StringCaseCompare.php
• JitVmHelperLink::ensureCompiled + lookupCompiled used
• StrcasecmpRuntimeShrinkTest green
• make bootstrap-selfhost-vm-driver-execute-probe green

Refs #1492, #15225, #23832

claim: PHP Runtime → PHP — starting this run

[PurHur]

Merged via #23863.

Verification:

• vendor/bin/phpunit test/unit/StrcasecmpRuntimeShrinkTest.php --filter testStringCaseCompareUsesJitVmHelperLink → OK (8 assertions)
• make bootstrap-selfhost-vm-driver-execute-probe → OK
• Pre-run baseline: make bootstrap-selfhost-link → OK; inventory check green

Shrink: −12 lines in lib/JIT/Builtin/StringCaseCompare.php (hand-rolled NestedJIT compile loop removed; uses shared JitVmHelperLink path).