Regression: EnumSpaceshipJit module verify fails NestedJIT ABI after getValue fix (re-#21109)

[PurHur]

Category

Regression · JIT emit / NestedJIT ABI · php-src-strict

Problem

After #21116 removed phantom JIT\Variable::getValue(), EnumSpaceshipJit no longer fatals on emit, but LLVM module verify still fails when compiling test/compliance/cases/language/enum_spaceship_jit.phpt.

Repro	Expected	Actual (post-#21116)
vendor/bin/phpunit --filter EnumSpaceshipJit	green	module verify: [8 x i8] icmp, __value__ bitcasts, preg_quote/?string, ExceptionHandler depth i32/i64

php-src reference

• php/php-src Zend/zend_enum.c — zend_compare_enum
• php/php-src Zend/zend_operators.c — compare_function / spaceship

PHP implementation target

• NestedJIT ABI for CompareJitHelper / ExceptionHandler / value-box loads (lib/JIT.php, ext/standard/JitSpaceshipCompareKernel.php, helpers)
• Prefer PHP-in-PHP NestedJIT fixes over new C

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter EnumSpaceshipJit'

Progress already on #21123

• numOnLeft i64; HashTable → __hashtable__*; CompareUnlikeHelper split; StatPath insert restore; enum_from phi dominance; ExceptionHandler empty-string ABI
• Cleared: spaceshipNumberString i32/i64, path_is_readable parentless, enum_from dominance, void*/string* select

Done when

• vendor/bin/phpunit --filter EnumSpaceshipJit green in pinned container
• Remaining NestedJIT verify errors above gone
• php-src-strict; no php-compiler-strict shortcut

[PurHur]

claim: lane-B compile/link automation — continuing NestedJIT EnumSpaceship work from closed #21109 handoff. PR: #21123

Pillar 1: user_release_ready=yes, inventory OK 6074/6074, north-star5-verify-fast OK.

Progress pushed: ABI fixes listed in PR (numOnLeft i64, HashTable __hashtable__*, CompareUnlikeHelper, StatPath restore, enum_from dominance, ExceptionHandler empty-string).

Still red: vendor/bin/phpunit --filter EnumSpaceshipJit — [8 x i8] icmp, __value__ bitcasts, ExceptionHandler depth slot, preg_quote ?string. Next run should attack those four.

[PurHur]

claim: lane-B implementer — continuing #21123

Compile (EnumSpaceshipJitCompileTest) is green. Next: MCJIT execute — route embed echo through php_write (ob-aware) + IR itoa for __phpc_ob_echo_ll so we avoid null-relocated libc snprintf/write/syscall.

[PurHur]

Merged #21123

Verification

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && export PHP_COMPILER_SKIP_LLVM_PRELOAD=1 && vendor/bin/phpunit --filter EnumSpaceshipJit'
# OK (2 tests, 7 assertions)
php script/bootstrap-inventory.php --check
# OK 6083/6083

MCJIT embed echo binds php_write (ob-aware); unit-enum <=> returns 1 for distinct singletons; name compare uses module-local memcmp.