Skip to content

Release v1.1.0: spine — add Locale canonicalize/parse compose files after #20750 #20752

Closed
#20761
#20759
Closed
Release v1.1.0: spine — add Locale canonicalize/parse compose files after #20750#20752
#20761
#20759
Labels
area:compilerCompiler / CFG / JITbugSomething isn't workingimplementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claimphase-0:FoundationPhase 0 – foundation & DevExrelease-blockerBlocks tagged user release

Description

@PurHur
PurHur
opened on Jul 19, 2026

Category

bootstrap · release gate (#78 v1.1.0) · Pillar 1 (Trust)

Problem

./script/release-readiness.sh --json fails on check-selfhost-spine-coverage-sync after #20750 landed Locale canonicalize/parse/compose/keywords helpers without updating test/selfhost/compiler_lib_spine_smoke/main.php.

check-selfhost-spine-coverage-sync: FAILED — 8 inventory files missing from spine:
  ext/intl/LocaleCanonicalize.php
  ext/intl/LocaleComposeLocale.php
  ext/intl/LocaleGetKeywords.php
  ext/intl/LocaleParseLocale.php
  ext/intl/locale_canonicalize.php
  ext/intl/locale_compose.php
  ext/intl/locale_get_keywords.php
  ext/intl/locale_parse.php

Downstream: north-star5-verify --fast fails → user_release_ready: no (quick).

Probe record (2026-07-19, maintainer, 1510ad5a2)

Gate Status
make bootstrap-selfhost-link ✅ OK
make bootstrap-selfhost-helloworld ✅ OK
php script/bootstrap-inventory.php --check ✅ OK 5818/5818
spine-coverage-sync 🔴 8 Locale* / locale_* files from #20750
north-star5-fast 🔴 (spine step)
vm-driver-probe ✅

Introduced by: #20750 / #20738 (Locale canonicalize/parseLocale/composeLocale/getKeywords)

Acceptance criteria

  • Add require_once for the 8 files above to test/selfhost/compiler_lib_spine_smoke/main.php (alpha order)
  • php script/check-selfhost-spine-coverage-sync.php → OK
  • ./script/docker-exec.sh -- bash -lc 'make north-star5-verify-fast' → green
  • ./script/release-readiness.sh --json → user_release_ready: yes (quick) / spine + north-star5-fast ok

Gate command

./script/docker-exec.sh -- bash -lc 'php script/check-selfhost-spine-coverage-sync.php'
./script/docker-exec.sh -- bash -lc 'make north-star5-verify-fast'
./script/release-readiness.sh --json

Fix hint:

php script/bootstrap-selfhost-next-includes.php \
  --bundle=test/selfhost/compiler_lib_spine_smoke/main.php --limit=8

Tracking

Activity

  1. PurHur
    added
    bugSomething isn't working
    phase-0:FoundationPhase 0 – foundation & DevEx
    area:compilerCompiler / CFG / JIT
    implementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claim
    release-blockerBlocks tagged user release
    on Jul 19, 2026

  2. PurHur commented on Jul 19, 2026

    @PurHur
    PurHur
    on Jul 19, 2026
    OwnerAuthor

    Filed from maintainer Trust probe on master 1510ad5a2 after #20750. Blocks user_release_ready — claim this before stdlib parity batches (see #10533).

  3. PurHur commented on Jul 19, 2026

    @PurHur
    PurHur
    on Jul 19, 2026
    OwnerAuthor

    claim: lane-B-implementer — starting this run

    Pillar 1 Trust blocker: spine missing Locale canonicalize/parse/compose/keywords after #20750. Will add the 8 requires, verify spine-sync + north-star5-verify-fast + release-readiness, then merge.

  4. PurHur commented on Jul 19, 2026

    @PurHur
    PurHur
    on Jul 19, 2026
    OwnerAuthor

    claim: lane-B-trust-gate — starting this run

    Confirming no open PR/branch for #20752. Taking Pillar 1 spine fix: add 8 Locale canonicalize/parse/compose/keywords requires, verify spine-sync + north-star5-verify-fast + release-readiness, then merge.

  5. PurHur
    added a commit that references this issue on Jul 19, 2026

    Bootstrap: spine-cover Locale canonicalize/parse/compose/keywords (#2…

    9863db3
  6. PurHur
    closed this as completedin #20759on Jul 19, 2026

  7. PurHur commented on Jul 19, 2026

    @PurHur
    PurHur
    on Jul 19, 2026
    OwnerAuthor

    Merged #20759

    Verification:

    • check-selfhost-spine-coverage-sync: OK (5818/5818)
    • north-star5-verify-fast: OK
    • release-readiness --json: user_release_ready: yes (5/5 quick)

    Added 8 Locale canonicalize/parse/compose/keywords requires to compiler_lib_spine_smoke/main.php after #20750.

  8. PurHur commented on Jul 19, 2026

    @PurHur
    PurHur
    on Jul 19, 2026
    OwnerAuthor

    Merged via #20761.

    Verification (post-fix):

    • php script/check-selfhost-spine-coverage-sync.php → OK (5818/5818)
    • make north-star5-verify-fast → OK
    • ./script/release-readiness.sh --json → user_release_ready: yes (spine + north-star5-fast + inventory + vm-driver-probe + readme)

    Pillar 1 Trust restored after #20750 Locale helpers.

  9. PurHur
    added a commit that references this issue on Jul 19, 2026

    Bootstrap: spine-cover Locale canonicalize/parse/compose after #20750 (…

    494a4d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:compilerCompiler / CFG / JITbugSomething isn't workingimplementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claimphase-0:FoundationPhase 0 – foundation & DevExrelease-blockerBlocks tagged user release

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions