CI: FILE_UPLOAD_WEB_DEPLOY_SMOKE_GATE opt-in in ci-local after #2028

[PurHur]

Problem

#2028 adds deploy-smoke.sh --example 006 for multipart CGI behind PHPC_DEPLOY_ROOT. There is no ci-local hook yet — same gap #1967 had for 005 before #1974 default-on flip.

Goal

When #2028 is green on php-compiler:22.04-dev:

1. FILE_UPLOAD_WEB_DEPLOY_SMOKE_GATE="${FILE_UPLOAD_WEB_DEPLOY_SMOKE_GATE:-0}" in script/ci-defaults.env
2. ci_run_file_upload_web_deploy_smoke() in script/ci-common.sh (llvm tail only; skip exit 0 when LLVM missing)
3. Wire into script/ci-local.sh after deploy-smoke / examples smokes
4. Document in docs/local-ci-matrix.md and lib/Doctor.php (DevEx: phpc doctor --gates lists 006-FileUploadWeb ladder (#1999–#2012) #2010 ladder)

Follow-up (separate issue): default =1 in ci-local after stable (mirror #1974 for sessions).

Implementation hints

Mirror SESSIONS_WEB_DEPLOY_SMOKE_GATE wiring:

Piece	Path	Notes
Smoke	script/deploy-smoke.sh	smoke_006_fileuploadweb() from #2028
Hook	script/ci-common.sh	Call only when gate 1 and LLVM ready
Test	test/unit/CiScriptsTest.php	Assert env var + hook string

Acceptance criteria

FILE_UPLOAD_WEB_DEPLOY_SMOKE_GATE=1 ./script/ci-local.sh
docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev \
  FILE_UPLOAD_WEB_DEPLOY_SMOKE_GATE=1 ./script/deploy-smoke.sh --example 006

Dependencies

• Testing: deploy-smoke multipart upload for 006-FileUploadWeb #2028 — deploy-smoke 006 implementation (blocker)
• CI: Default FILE_UPLOAD_WEB_AOT_SMOKE_GATE=1 in ci-local after #2011 green #2012 ✅ — AOT execute recommended green first
• Testing: 005-SessionsWeb phpc deploy + PHPC_DEPLOY_ROOT CGI smoke #1893 ✅ — 005 deploy precedent

Links

• ROADMAP 🗺️ ROADMAP: Self-host + web-capable PHP subset (living) #78 · CI: FILE_UPLOAD_WEB_DEPLOY_SMOKE_GATE opt-in in ci-local after #2028 #2038

[PurHur]

Ladder (batch 116): Opt-in gate in ci-local.sh → default-on sibling #2042. Same pattern as #1921 → #1923 (005 AOT) and #1967 → #1974 (005 deploy).

Combined presenter target: #2077 + ci hook #2085 (DEPLOY_SMOKE_ALL_GATE).

[PurHur]

Staged pair: this issue = opt-in gate (:-0). Default-on flip tracked in #2042 after deploy smoke is stable — do not implement both in one PR.

[PurHur]

Staged with #2042 (default-on flip). Do not implement both in one PR. ROADMAP #78 de-dupe table updated. Verify with FILE_UPLOAD_WEB_DEPLOY_SMOKE_GATE=1 ./script/deploy-smoke.sh --example 006 then make test-harness — not GHA.

[PurHur]

Parity architect refresh (2026-06-05) — implementation-ready spec

Category: area:tooling (CI gate only — no compiler semantics)

Problem (unchanged)

After #2028 lands deploy-smoke.sh --example 006 (multipart upload under PHPC_DEPLOY_ROOT), this repo still lacks a default-off → opt-in → default-on ci-local hook (same ladder as #1974 for sessions).

Acceptance repro (gate off = no-op)

FILE_UPLOAD_WEB_DEPLOY_SMOKE_GATE=0 ./script/ci-local.sh
# must complete without invoking example 006 smoke

Acceptance repro (gate on = runs smoke)

FILE_UPLOAD_WEB_DEPLOY_SMOKE_GATE=1 ./script/ci-local.sh
# after LLVM phases: calls script/deploy-smoke.sh example 006
# requires: docker image php-compiler:22.04-dev, loopback, PHPC_DEPLOY_ROOT

Files to touch

Piece	Path
Default	script/ci-defaults.env — FILE_UPLOAD_WEB_DEPLOY_SMOKE_GATE="${FILE_UPLOAD_WEB_DEPLOY_SMOKE_GATE:-0}"
Hook	script/ci-common.sh — ci_run_file_upload_web_deploy_smoke()
Wire	script/ci-local.sh — after existing deploy-smoke / examples block
Docs	docs/local-ci-matrix.md, lib/Doctor.php (#2010 ladder)
Test	test/unit/CiScriptsTest.php — assert env var + hook symbol present

Done when

• Gate 0 → smoke not invoked (unit test asserts)
• Gate 1 + LLVM available → deploy-smoke.sh 006 path runs; skip exit 0 if LLVM missing (mirror sessions gate)
• docs/local-ci-matrix.md documents env var
• Follow-up issue filed for default =1 after one week stable (mirror CI: Default SESSIONS_WEB_DEPLOY_SMOKE_GATE=1 in ci-local after #1967 green #1974)

Blocker

• Testing: deploy-smoke multipart upload for 006-FileUploadWeb #2028 must be merged/green first (smoke function exists)

Not in scope: compiler move_uploaded_file semantics (#2005, #5346 php-in-php upload temp).

[PurHur]

claim: worker-lane-B — starting this run

[PurHur]

Verified on master — already delivered in #2028 (no additional PR needed).

Lane B worker checked acceptance criteria against current master:

Gate wiring (all present)

• script/ci-defaults.env: FILE_UPLOAD_WEB_DEPLOY_SMOKE_GATE="${FILE_UPLOAD_WEB_DEPLOY_SMOKE_GATE:-0}"
• script/ci-common.sh → ci_run_deploy_smoke() calls deploy-smoke.sh --example 006 when gate =1 (same pattern as 005 sessions gate)
• script/ci-local.sh invokes ci_run_deploy_smoke in the LLVM tail
• docs/local-ci-matrix.md + lib/Doctor.php document the gate

Verification (Docker php-compiler:22.04-dev)

# Gate off — no-op smoke
FILE_UPLOAD_WEB_DEPLOY_SMOKE_GATE=0 ./script/deploy-smoke.sh --example 006
# → deploy-smoke: 006-FileUploadWeb: skip (FILE_UPLOAD_WEB_DEPLOY_SMOKE_GATE=0 #2028)
# → exit 0

# Unit tests (wiring)
vendor/bin/phpunit test/unit/CiScriptsTest.php --filter 'FileUploadWebDeploy|DeploySmokeGate|testCiLocalHonorsDeploySmokeGate'
# → OK (7 tests)

vendor/bin/phpunit test/unit/DeploySmokeScriptTest.php --filter Example006SkipsWhenGateOff
# → OK

Follow-up default-on flip remains #2042 (separate issue, do not combine).

Closing as duplicate-of-delivery: opt-in ci-local hook landed with deploy-smoke 006 implementation (#2028).