php-in-php: delete StringHashCryptoJit NestedJit defer — thin via isThinStandaloneAotMain + real hash_equals (re-#20050)

[PurHur]

Category

php-in-php · runtime-shrink (#1492, re-#20050 / #19362)

Problem

lib/JIT/Builtin/StringHashCryptoJit.php still gates the thin JitHashCryptoKernel path behind UserScriptAotDeferNestedJit::shouldDefer() (env PHP_COMPILER_AOT_USER_SCRIPT). On that deferred path it also emits hash_equals_deferred_stub that always returns 0 — so user-script AOT hash_equals() is permanently false.

#20050 / StringHashAlgos replaced the NestedJit defer gate with Context::isThinStandaloneAotMain() so bootstrap thin standalone and user-script AOT share one path without the NestedJit audit surface.

php-src reference

• php/php-src ext/hash/hash.c — PHP_FUNCTION(hash) / hash_equals / HMAC / PBKDF2 / HKDF

PHP implementation target

• lib/JIT/Builtin/StringHashCryptoJit.php — replace UserScriptAotDeferNestedJit::shouldDefer with $context->isThinStandaloneAotMain(); thin → JitHashCryptoKernel + real StringHashEquals::ensureLinked (delete hash_equals_deferred_stub); embed/non-thin stays StringHashCryptoPhp / JitVmHelperLink
• test/unit/StringHashCryptoRuntimeShrinkTest.php — assert no UserScriptAotDeferNestedJit; assert isThinStandaloneAotMain; assert no hash_equals_deferred_stub

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
vendor/bin/phpunit test/unit/StringHashCryptoRuntimeShrinkTest.php test/unit/StringHashEqualsRuntimeShrinkTest.php
vendor/bin/phpunit --filter HashEqualsBuiltinTest
make bootstrap-selfhost-vm-driver-execute-probe
'

Done when

• UserScriptAotDeferNestedJit removed from StringHashCryptoJit.php
• Thin path gated by isThinStandaloneAotMain (php-in-php: delete StringHashAlgos/HmacAlgos NestedJit defer — thin standalone via JitHashAlgosKernel (re-#19355) #20050 / Rename shape)
• hash_equals_deferred_stub deleted; thin path links real StringHashEquals
• Shrink tests green
• make bootstrap-selfhost-vm-driver-execute-probe green
• PR body cites NestedJit defer call sites removed

Refs #1492, #20050, #19362, #10533

[PurHur]

claim: PHP Runtime → PHP — starting this run.

Gates (before claim):

Gate	Status
bootstrap-inventory --check	OK 5414/5414
release-readiness --json	user_release_ready: **yes**
north-star5-fast / spine / vm-driver-probe	ok

Plan: replace UserScriptAotDeferNestedJit with isThinStandaloneAotMain; delete hash_equals_deferred_stub; thin → JitHashCryptoKernel + real StringHashEquals (#20050 shape).

[PurHur]

Merged via #20069 (895b041c1).

Verification (pre-merge):

• Shrink + standalone + HashEqualsBuiltin OK
• User-script AOT hash_equals → 1\n0 via JitHashEqualsKernel (no deferred stub)
• inventory/spine 5426/5426 after master ftp/pcntl/exif drift sync
• north-star5-verify-fast OK · vm-driver-probe OK

Shrink: removed UserScriptAotDeferNestedJit + always-false hash_equals_deferred_stub from StringHashCryptoJit; thin path uses isThinStandaloneAotMain + JitHashEqualsKernel XOR LLVM.