Regression: gzencode/gzdeflate/gzcompress(null) — declare(strict_types=1) call edge ignored (re-#19023, ext/zlib/zlib.c)

[PurHur]

Category

stdlib · php-src-strict · declare(strict_types=1) call-site edge

Problem

#19023 restored php-src null→'' coercion for zlib one-shots on the default profile when the caller is not strict. Callers compiled with declare(strict_types=1) must still get a call-edge TypeError before callee coercion — Zend does; this compiler still coerces and runs the builtin.

Repro	Zend 8.2+	VM (2026-07-15)
declare(strict_types=1); gzencode(null);	TypeError	coerces → compressed payload
same for gzdeflate(null), gzcompress(null)	TypeError	coerces

Loose callers (no strict_types) should keep php-src coercion from #19023; this issue is only the strict call edge.

php-src reference

• php/php-src ext/zlib/zlib.c — PHP_FUNCTION(gzencode) / gzdeflate / gzcompress + ZEND_CHECK_ARG_TYPE at call site

PHP implementation target

• ext/standard/VmZlib.php / VmZlibCore.php — route $data through shared strict call-edge guard before coercion
• lib/JIT/Builtin/ZlibRuntime.php (and helpers) — mirror VM strict edge for JIT/AOT
• No new C in runtime/

Repro

./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_zlib_null_strict_types_edge.php'
# Zend: strict_edge_ok · VM: gzencode: fail expected TypeError (exit 1)

Done when

• maintainer_gap_zlib_null_strict_types_edge.php green on VM/JIT/AOT
• Loose-profile repro maintainer_gap_zlib_null_default.php stays green (no regression)
• Compliance guard under test/compliance/cases/stdlib/zlib_strict_types_null.phpt
• php-src-strict; no php-compiler-strict shortcut

[PurHur]

claim: cursor-agent-lane-c — starting this run (gzencode/gzdeflate/gzcompress null + declare(strict_types=1) call-edge TypeError)

[PurHur]

Merged via PR #19123.

Fix: Route gzencode() / gzdeflate() / gzcompress() $data through VmString::stringBuiltinArgForFrame() (VM) and JitStringBuiltinArg::lowerStrictOrCoercible() (JIT) so declare(strict_types=1) callers get call-edge TypeError before callee coercion (php-src ext/zlib/zlib.c). Loose callers keep #19023 null→'' coercion.

Verification:

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php bin/vm.php test/repro/maintainer_gap_zlib_null_strict_types_edge.php'
# strict_edge_ok

php bin/vm.php test/repro/maintainer_gap_zlib_null_default.php
# ok

vendor/bin/phpunit --filter zlib_strict_types_null'
# OK (4 tests) — VM + JIT compliance