Skip to content

php-in-php: delete ProcessExecCaptureLlvm — JitVmHelperLink + ProcessExecCaptureNativeJitHelper PHP (#1492) #19006

Description

@PurHur

Category

php-in-php · runtime-shrink (#1492)

Problem

lib/JIT/Builtin/ProcessExecCaptureLlvm.php (~144 LOC) hand-lowers __compiler_process_exec_capture for user-script standalone AOT because nested ProcessExecCaptureNativeJitHelper compile segfaulted during minimal init (#10492, #15407). The same semantics already live in ext/standard/ProcessExecCaptureNativeJitHelper.php (VmShellExecNative + phpc_native_ht_*). JitVmHelperLink::ensureCompiled + prelinked helper-runtime units (#15889) now avoid nested JIT during deferred init — same pattern as #18990 (InArrayNativeLlvm deletion).

php-src reference

PHP implementation target

  • lib/JIT/Builtin/ProcessRuntime.php — route deferred AOT through JitVmHelperLink::ensureCompiled + existing implementExecCaptureNativeBridge
  • Delete lib/JIT/Builtin/ProcessExecCaptureLlvm.php

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php vendor/bin/phpunit test/unit/ProcessRuntimeShrinkTest.php test/unit/ExecJitRuntimeShrinkTest.php'

Done when

  • ProcessExecCaptureLlvm.php deleted; shrink test updated
  • __compiler_process_exec_capture ABI defined via JitVmHelperLink bridge
  • make bootstrap-selfhost-vm-driver-execute-probe green
  • PR body cites ~144 lines removed from LLVM monolith

Refs #1492, #10492, #9337

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:compilerCompiler / CFG / JITenhancementNew feature or requestimplementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claimphase-0:FoundationPhase 0 – foundation & DevEx

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions