Skip to content

CI: Default BOOTSTRAP_LIB_SPINE_VM_SMOKE_GATE=1 in ci-local (#1846 follow-up) #1867

Description

@PurHur

Problem

#1846 ✅ landed script/bootstrap-selfhost-lib-spine-vm-smoke.sh — the M2 spine AOT binary runs bin/vm.php -r with PHP_COMPILER_VM_SPINE_SMOKE=1 and prints vm-spine-ok. CI wiring exists in script/ci-common.sh but BOOTSTRAP_LIB_SPINE_VM_SMOKE_GATE defaults to 0 in script/ci-defaults.env.

Full ./script/ci-local.sh therefore validates native link of the spine bundle but not the real vm.php driver path on that binary — a gap on the road to M5 (#1521).

Goal

  1. Default BOOTSTRAP_LIB_SPINE_VM_SMOKE_GATE=1 in script/ci-defaults.env once Self-host M2: land final 3 ext/standard Vm* units in compiler_lib_spine_smoke (578→586) #1821 spine units are green (584→586)
  2. Opt-out: BOOTSTRAP_LIB_SPINE_VM_SMOKE_GATE=0 for spine-only link PRs
  3. Update docs/local-ci-matrix.md and phpc doctor --gates
  4. Include in DevEx: make north-star2-verify presenter gate (self-host M0–M4) #1865 north-star2-verify step 4

Acceptance criteria

Dependencies

Verify

BOOTSTRAP_LIB_SPINE_VM_SMOKE_GATE=1 make bootstrap-selfhost-lib-spine-vm-smoke
# Docker:
docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev \
  env BOOTSTRAP_LIB_SPINE_VM_SMOKE_GATE=1 make bootstrap-selfhost-lib-spine-vm-smoke

Links

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions