Skip to content

Stdlib: ReflectionMethod::getTentativeReturnType() missing — hasTentativeReturnType only (ext/reflection/php_reflection.c) #18226

Closed
#18240
#18233
Closed
Stdlib: ReflectionMethod::getTentativeReturnType() missing — hasTentativeReturnType only (ext/reflection/php_reflection.c)#18226
#18240
#18233
Labels
area:vmVirtual machineenhancementNew feature or requestimplementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claimphase-4:stdlibPhase 4 – stdlib for web appsstdlib

Description

@PurHur
PurHur
opened on Jul 12, 2026

Category

stdlib · php-src-strict

Problem

PHP 8.1+ exposes tentative return types on internal/builtin methods. This compiler wires ReflectionMethod::hasTentativeReturnType() but not the paired getter getTentativeReturnType(), so code expecting a ReflectionNamedType (or null) cannot mirror Zend.

Repro Zend 8.2+ VM (2026-07-12)
method_exists(new ReflectionMethod('DateTime','format'), 'getTentativeReturnType') true false
(new ReflectionMethod('DateTime','format'))->getTentativeReturnType()?->getName() 'string' fatal: undefined method

php-src reference

PHP implementation target

  • lib/VM/Builtin/ReflectionMethodGetTentativeReturnType.php — mirror ReflectionMethodGetReturnType.php / existing ReflectionMethodHasTentativeReturnType.php
  • Share type-object construction with lib/VM/ReflectionSupport.php

Repro

./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_reflection_method_get_tentative_return_type.php'
# fail: getTentativeReturnType missing

Done when

  • test/repro/maintainer_gap_reflection_method_get_tentative_return_type.php prints ok name=string on VM/JIT/AOT
  • Compliance .phpt guard under test/compliance/cases/stdlib/reflection_method_get_tentative_return_type.phpt
  • php-src-strict; no php-compiler-strict shortcut

Activity

  1. PurHur
    added
    enhancementNew feature or request
    phase-4:stdlibPhase 4 – stdlib for web apps
    area:vmVirtual machine
    implementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claim
    stdlib
    on Jul 12, 2026

  2. PurHur commented on Jul 12, 2026

    @PurHur
    PurHur
    on Jul 12, 2026
    OwnerAuthor

    claim: PHP Compiler STD Lib Advanced — batch (issues #18225, #18226, #18228)

  3. PurHur commented on Jul 12, 2026

    @PurHur
    PurHur
    on Jul 12, 2026
    OwnerAuthor

    claim: cursor-agent-lane-b — starting this run

  4. PurHur
    added a commit that references this issue on Jul 12, 2026

    Reflection: register ReflectionMethod predicate APIs (#18225, #18226, #…

    0a82815
  5. PurHur
    closed this as completedin #18233on Jul 12, 2026

  6. PurHur commented on Jul 12, 2026

    @PurHur
    PurHur
    on Jul 12, 2026
    OwnerAuthor

    Merged in #18233 — VM repro + compliance guards green; bootstrap inventory + spine sync + VM driver probe OK.

  7. PurHur
    added 2 commits that reference this issue on Jul 12, 2026

    Merge master and expand tentative return metadata (#18226)

    1723a6a

    ReflectionMethod::getTentativeReturnType() for internal methods (#18226…

    67299f5

  8. PurHur commented on Jul 12, 2026

    @PurHur
    PurHur
    on Jul 12, 2026
    OwnerAuthor

    Merged via #18240

    Verification

    ./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php test/repro/maintainer_gap_reflection_method_get_tentative_return_type.php
php bin/vm.php test/repro/maintainer_gap_reflection_method_get_tentative_return_type.php'
# method_yes / name=string / has_yes / user_has_no / user_get_null / ok name=string

vendor/bin/phpunit --filter reflection_method_get_tentative_return_type
# OK (2 tests)

    Implementation: ReflectionMethod::getTentativeReturnType() VM builtin + BuiltinInternalTentativeReturnInfo Zend 8.2 snapshot (187 internal methods); hasTentativeReturnType() now consults the same table via BuiltinInternalArgInfo::tentativeReturnTypeForClassMethod().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:vmVirtual machineenhancementNew feature or requestimplementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claimphase-4:stdlibPhase 4 – stdlib for web appsstdlib

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions