Skip to content

CI: Default WAVE3_ROADMAP_SYNC_GATE=1 in ci-fast after #1811 doc sync #1814

Description

@PurHur

Problem

#1802 ✅ added script/check-wave3-roadmap-sync.php and Wave3RoadmapSyncTest, but the gate is opt-in (WAVE3_ROADMAP_SYNC_GATE=1). docs/roadmap-wave3.md drifted again (lists closed wave-3 issues as open).

Contributors can merge language/stdlib PRs without updating the wave-3 table until someone manually runs the checker.

Goal

After #1811 lands (doc matches 12/13 + 13/13):

  1. Default WAVE3_ROADMAP_SYNC_GATE=1 in script/ci-defaults.env
  2. Run ci_run_wave3_roadmap_sync() from script/ci-fast.sh (already wired in ci-common.sh)
  3. Opt-out: WAVE3_ROADMAP_SYNC_GATE=0 for doc-only iteration
  4. Document in docs/README.md and phpc doctor --gates if applicable

Implementation hints

File Change
script/ci-defaults.env WAVE3_ROADMAP_SYNC_GATE="${WAVE3_ROADMAP_SYNC_GATE:-1}"
script/ci-fast.sh Ensure ci_run_wave3_roadmap_sync called (verify #1802 wiring)
test/unit/CiScriptsTest.php Assert default-on in ci-fast
docs/roadmap-wave3.md Must pass checker before flip PR merges

Acceptance criteria

./script/ci-fast.sh   # includes wave3 sync without manual export
docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev ./script/ci-fast.sh

Fails with clear message when docs/roadmap-wave3.md drifts from #1380 / spine counts.

Dependencies

Non-goals

Links

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions