Repository navigation
Regression: #[\NoDiscard] builtin attribute class missing on 8.4 profile (re-#16826, Zend/zend_attributes.c) #16977
Description
Category
language · php-src-strict · PHP 8.4 built-in attributes
Problem
#16826 was closed but NoDiscard is still not registered as an internal attribute class on PHP_COMPILER_PROFILE=8.4. User code #[NoDiscard] function f(): int cannot compile; class_exists('NoDiscard') is false.
| Repro | Zend 8.4 | VM 8.4 profile (2026-07-06) |
|---|---|---|
class_exists('NoDiscard') |
true (internal) |
false ❌ |
#[NoDiscard] function f(): int { return 1; } |
compiles + warns on ignored return | builtin class missing ❌ |
php-src reference
- php/php-src
Zend/zend_attributes.c—zend_attribute_registerforNoDiscard - php/php-src
Zend/zend_constants.h—ZEND_ACC_NODISCARDhandling
PHP implementation target
lib/CompilerVersion.php/ builtin attribute registration — register internalNoDiscardon 8.4 forward profile (mirrorOverride,SensitiveParameter)- VM: emit
E_WARNINGwhen return value of#[NoDiscard]call is discarded (php-src-strict)
Repro
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/maintainer_gap_nodiscard_attribute_class.php'
# fail: NoDiscard builtin attribute class missing on PHP_COMPILER_PROFILE=8.4Done when
-
class_exists('NoDiscard')true;ReflectionClass::isInternal()true on 8.4 profile -
#[NoDiscard]on functions/methods compiles; discarded return triggers Zend-matching warning - Compliance guard under
test/compliance/cases/language/attributes/ - php-src-strict
Activity
PurHur commentedon Jul 6, 2026
claim: cursor-agent-lane-a — starting this run
PurHur commentedon Jul 6, 2026
claim released: maintainer_gap_nodiscard_attribute_class.php green on master with PHP_COMPILER_PROFILE=8.4 (class_exists + #[NoDiscard] compile). Pivoting to get_defined_functions exclude_disabled forward-profile regression.
PurHur commentedon Jul 6, 2026
claim: cursor-agent-lane-c — starting this run
PurHur commentedon Jul 6, 2026
claim released: repro green on master with PHP_COMPILER_PROFILE=8.4 — pivoting to #10775 array_reduce inline literal.
PurHur commentedon Jul 6, 2026
claim: cursor-agent-lane-c — phantom gate fix (advertises*AttributeClass must not inherit harness PHP_COMPILER_PROFILE=8.4)
Fix NoDiscard builtin attribute phantom gate on 8.4.0-dev reference p…
PurHur commentedon Jul 6, 2026
Merged via #17017
Fix: Forward-profile builtin attribute classes (
NoDiscard,Override,EnumCases,DelayedTargetValidation,CompileTime) now useadvertisesForwardProfile84BuiltinAttributeClass()— enabled on stable 8.4.0+ or explicitPHP_COMPILER_PROFILEopt-in, withheld on8.4.0-devreference when profile is unset (even if harness exports8.4globally).Verification:
env -u PHP_COMPILER_PROFILE php bin/vm.php test/repro/maintainer_gap_nodiscard_registration.php→okPHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/maintainer_gap_nodiscard_attribute_class.php→1vendor/bin/phpunit test/unit/BuiltinAttributePhantomTest.php→ OK