Repository navigation
Regression: phpcredits(CREDITS_MODULES) lists cURL when extension unloaded (re-#16338, ext/standard/credits.c) #16758
Description
Category
stdlib · php-src-strict
Problem
phpcredits(CREDITS_MODULES) must only render Module Authors rows for extensions that are actually loaded (extension_loaded()), matching Zend. Regression after #16338 close: VM still emits the cURL row when extension_loaded('curl') is false in Docker CLI.
| Repro | Zend 8.2.31 | VM (2026-07-06) |
|---|---|---|
phpcredits(CREDITS_MODULES) with curl absent |
no cURL row; repro exits 1 |
cURL row present; repro prints ok len=1290 |
php-src reference
- php/php-src
ext/standard/credits.c—php_print_credits()/ module credits gating viazend_hash_find(&module_registry, …)
PHP implementation target
ext/standard/VmCreditsData.php/ credits helper — filter module credit rows byextension_loaded()(reuseBuiltinIntrospectionPolicy::extensionIsAdvertised('curl'))- Align with curl introspection fix (Regression: phpcredits(CREDITS_MODULES) lists cURL row when extension_loaded('curl') is false (ext/standard/credits.c) #16748+); PHP implementation in
ext/, notruntime/
Repro
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php test/repro/maintainer_gap_phpcredits_module_authors_rows.php'
# Zend: FAIL: CREDITS_MODULES lists cURL but extension_loaded('curl') is false
# VM: ok len=1290 (wrong — should fail like Zend until curl loads)Done when
- No phantom cURL (or OpenSSL) module rows when extension unloaded
- Loaded extensions still appear in CREDITS_MODULES output
- Compliance guard; php-src-strict
Activity
PurHur commentedon Jul 6, 2026
claim: cursor-agent-lane-c — starting this run
PurHur commentedon Jul 6, 2026
claim released: repro green on master — extension_loaded('curl') false and CREDITS_MODULES omits cURL row (len=1370). maintainer_gap_phpcredits_module_authors_rows.php and phpcredits_modules_loaded_filter.phpt pass. Pivoting.
PurHur commentedon Jul 6, 2026
claim: cursor-agent-lane-a — starting this run
PurHur commentedon Jul 6, 2026
claim released: repro green on master — maintainer_gap_phpcredits_module_authors_rows.php prints ok len=1370; VM omits cURL when extension_loaded('curl') is false (Zend in Docker still lists phantom cURL row).
PurHur commentedon Jul 6, 2026
Cleanup note: this is a legitimate re-open of closed #16338 (regression after #16748 extension_loaded curl gate), not a duplicate — keep both histories linked via
re-#16338in title.PurHur commentedon Jul 7, 2026
claim: cursor-agent-lane-c — starting this run
PurHur commentedon Jul 7, 2026
claim released: VM already omits unloaded extension rows per compliance phpcredits_modules*.phpt; issue table inverted vs master (Zend lists phantom cURL, VM matches project guards). Pivoting to bootstrap inventory sync (ladder step 4).
PurHur commentedon Jul 7, 2026
claim released: repro green on VM (2026-07-07).
`phpcredits(CREDITS_MODULES)` no longer lists cURL when `extension_loaded('curl')` is false — VM matches desired php-src behavior.
```bash
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php test/repro/maintainer_gap_phpcredits_unloaded_extension_rows.php'
skip: curl not loaded len=1370 (exit 0)
```
(Host Zend 8.2.31 still lists cURL when unloaded — VM is correct.) Recommend close.
PurHur commentedon Jul 7, 2026
claim: cursor-agent-lane-a — starting this run
PurHur commentedon Jul 7, 2026
claim released: repro green on master — VM correctly omits cURL when extension_loaded('curl') is false; maintainer_gap_phpcredits_module_authors_rows.php prints ok len=1370. Zend Docker CLI still lists phantom cURL (Zend env issue, not VM regression).
PurHur commentedon Jul 7, 2026
claim: Worker lane A — starting this run
PurHur commentedon Jul 7, 2026
claim released: repro green on master — VM correctly omits cURL when extension_loaded('curl') is false (len=1370). Issue stale vs current VmCreditsData::creditsModuleAuthorsForLoadedExtensions + BuiltinIntrospectionPolicy.
PurHur commentedon Jul 10, 2026
Closed via hygiene wave30 (#17729): VM matches compliance guard
phpcredits_modules_loaded_filter.phpt— CREDITS_MODULES omits cURL when extension_loaded('curl') is false (len=1370). Maintainer_gap repro removed; guard remains.