Repository navigation
Regression: WeakMap/WeakReference inside closure — offsetGet/get() NULL again (re-#13923, Zend/zend_weakrefs.c) #14132
Description
Category
stdlib · php-src-strict · regression (re-#13923)
Problem
#13923 was closed 2026-06-30 but closure-scoped weak refs are still broken on VM: WeakMap offset read and WeakReference::get() return NULL inside a user closure while top-level access works.
php-src reference
Zend/zend_weakrefs.c—zend_weakmap_offset_get,zend_weakref_getZend/zend_closures.c— closure frame object retention
Repro (verified 2026-06-30)
test/repro/maintainer_gap_weakmap_closure_offsetget.php
test/repro/maintainer_gap_weakreference_closure_get.php
./script/docker-exec.sh -- php bin/vm.php test/repro/maintainer_gap_weakmap_closure_offsetget.php # TypeError: int return, null given
./script/docker-exec.sh -- php bin/vm.php test/repro/maintainer_gap_weakreference_closure_get.php # exit 1| Check | Zend | VM |
|---|---|---|
(fn(): int => { $wm=new WeakMap(); $o=new stdClass(); $wm[$o]=9; return $wm[$o]; })() |
9 |
NULL |
(fn(): bool => { $o=new stdClass(); return WeakReference::create($o)->get()===$o; })() |
true |
false |
Done when
- Both repro scripts print
okonphp bin/vm.php(php-src-strict). - No new C in
runtime/— fix inlib/VM.php/ weak-ref registry PHP path (php-in-php: JIT WeakRefRegistryRuntime — route WeakMap/WeakReference registry through VmWeakRefRegistry PHP not phpc_weakref LLVM (#1492) #9191).
Activity
PurHur commentedon Jun 30, 2026
claim: worker-lane-c — batch (issues #14132)
Fix WeakMap/WeakReference alive checks inside closures (#14132). (#14137
PurHur commentedon Jun 30, 2026
Merged via #14137.
Fix: `hasStrongScopeBinding()` now scans the active `executingFrame` (closure / parent-linked) in addition to `runStack` suspended callers — closure locals were invisible to weak-ref alive checks.
Verification:
```bash
./script/docker-exec.sh -- php bin/vm.php test/repro/maintainer_gap_weakmap_closure_offsetget.php # ok
./script/docker-exec.sh -- php bin/vm.php test/repro/maintainer_gap_weakreference_closure_get.php # ok
./script/docker-exec.sh -- ./vendor/bin/phpunit test/unit/WeakReferenceWeakMapTest.php # OK (21 tests)
```
PurHur commentedon Jun 30, 2026
claim: PHP Compiler STD Lib — batch (issues #14132)
PurHur commentedon Jun 30, 2026
Merged via #14138 — VM repros green; WeakReferenceWeakMapTest 19/19; AOT lint on weakmap closure repro exit 0.
Merge origin/master; keep visitNamedStrongRefRoots for #14132.
Fix WeakMap/WeakReference liveness inside closures (#14132). (#14138)
Fix return-type TypeError getTrace() for VM bridge throws (#14369). (#…