Repository navigation
Regression: fgetcsv() separator argument — empty/null accepted, Zend ValueError/TypeError (ext/standard/file.c) #12018
Description
Category
stdlib · php-src-strict
Problem
fgetcsv() $separator validation is too permissive. Zend rejects invalid separators; VM parses rows anyway.
$separator |
Zend | VM |
|---|---|---|
'' (empty string) |
ValueError: … must be a single character |
parses ['a','b'] ❌ |
null |
TypeError (string expected) |
parses uncaught ❌ |
',' |
success | success ✓ |
Distinct from #8975 (enum case operands) and #9303 (escape/enclosure parsing).
php-src reference
- php/php-src
ext/standard/file.c—php_fgetcsv, separator length guard
PHP implementation today
ext/standard/fgetcsv.php,ext/standard/VmCsv.php(or equivalent CSV helper)
Repro
test/repro/maintainer_gap_fgetcsv_separator_validation.php(empty'')test/repro/maintainer_gap_fgetcsv_null_separator_typeerror.php(null)
./script/docker-exec.sh -- php test/repro/maintainer_gap_fgetcsv_separator_validation.php # Zend: ok
./script/docker-exec.sh -- php bin/vm.php test/repro/maintainer_gap_fgetcsv_separator_validation.php # VM: fail
./script/docker-exec.sh -- php test/repro/maintainer_gap_fgetcsv_null_separator_typeerror.php
./script/docker-exec.sh -- php bin/vm.php test/repro/maintainer_gap_fgetcsv_null_separator_typeerror.phpImplementation hints (PHP-in-PHP)
- Reuse
VmString::coerceStringBuiltinArg/ strict arg guards: separator must be exactly one byte - Reject
nullwithTypeErrorbefore IO - Mirror
str_getcsv()separator rules for consistency
Done when
- Both repro scripts print
okon VM - Valid
fgetcsv($fp, 0, ',', '"', '\\')unchanged - Compliance
.phptguard committed
Activity
PurHur commentedon Jun 26, 2026
claim: PHP Compiler STD Lib — batch (issues #12018, #12017)
fgetcsv(): reject empty separator/enclosure per php-src (#12018) (#12022
PurHur commentedon Jun 26, 2026
Merged via #12022. VM + JIT compliance + AOT compile-only guard green in Docker.
PurHur commentedon Jul 5, 2026
claim: cursor-agent-lane-a — named separator: null misbinds to length slot (compileCallArgs null fast path skips nameSlot); reopening binding aspect of #12018.
Fix fgetcsv() named separator: null misbind to $length slot (#12018) (#…
PurHur commentedon Jul 5, 2026
Merged via #16327.
Fix:
compileCallArgSends()registerscallArgNameSlotbefore null-literal fast-pathTYPE_ARG_SEND, sofgetcsv($fp, separator: null)binds to$separatornot$length.Verify:
→
ok(ValueError on argument #3).