php-in-php: JIT EnumCasesHelper — route Enum::cases() LLVM through VmEnum PHP not inline HashTable glue (#1492)

[PurHur]

Category

php-in-php · shrink LLVM · php-src-strict

Problem

Synthetic Enum::cases() lowering lives in lib/JIT/EnumCasesHelper.php with inline HashTableHelper::alloc + per-case LLVM stores (#3308, #4068). VM enum case lists are already specified in lib/VM/EnumSupport.php / BackedEnumFromJit territory (#10273), but EnumCasesHelper still duplicates ordering/materialization in JIT-only glue.

Route JIT/AOT through VmEnum::casesList() (or shared PHP helper) with thin ABI — same strategy as #10273 BackedEnumFromJit.

php-src reference

• php/php-src Zend/zend_enum.c — zend_enum_list_cases
• php/php-src Zend/zend_interfaces.c — case object order

Repro (drift guard)

<?php
enum Color: string { case Red = 'r'; case Green = 'g'; case Blue = 'b'; }
$cases = Color::cases();
echo count($cases), ':', $cases[0]->name, ':', $cases[2]->name, "\n";

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php -r "enum Color: string { case Red=\"r\"; case Green=\"g\"; case Blue=\"b\"; } \$c=Color::cases(); echo count(\$c),\":\",\$c[0]->name,\":\",\$c[2]->name,PHP_EOL;"
php bin/vm.php -r "enum Color: string { case Red=\"r\"; case Green=\"g\"; case Blue=\"b\"; } \$c=Color::cases(); echo count(\$c),\":\",\$c[0]->name,\":\",\$c[2]->name,PHP_EOL;"
php bin/jit.php -r "enum Color: string { case Red=\"r\"; case Green=\"g\"; case Blue=\"b\"; } \$c=Color::cases(); echo count(\$c),\":\",\$c[0]->name,\":\",\$c[2]->name,PHP_EOL;" 2>/dev/null || true
'

Check	VM/JIT must match
Count	3
Order	declaration order (Red … Blue)
Case type	enum case objects, not backing scalars

Scope (this repo)

Path	Work
lib/VM/EnumSupport.php	SSOT casesForClass() callable from JIT
lib/JIT/EnumCasesHelper.php	shrink to trampoline
lib/JIT/BackedEnumFromJit.php	share case materialization with #10273
Tests	test/compliance/cases/language/enum_cases.phpt

Done when

• Repro green on VM and JIT with identical case objects
• EnumCasesHelper.php no longer duplicates enum order logic from VM
• PR notes lines removed from JIT enum glue
• ./script/ci-fast.sh --filter enum_cases green

Related

• php-in-php: JIT BackedEnumFromJit — route BackedEnum::from/tryFrom LLVM through VmEnum PHP not ~514-line monolith (#1492) #10273 BackedEnumFromJit · Language: UnitEnum::cases() / BackedEnum::cases() — list enum cases (PHP 8.1, Zend parity) #3308 · Language: Enum::cases() — JIT/AOT case list lowering (phase 2 of #3308) #4068 · Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492

[PurHur]

claim: agent-lane-c — starting this run

[PurHur]

Merged via #10397.

Verification

• Issue repro: Zend / VM / JIT all print 3:Red:Blue
• ./vendor/bin/phpunit test/unit/EnumCasesJitHelperTest.php — OK
• ./vendor/bin/phpunit test/unit/EnumCasesJitExecuteTest.php — OK
• ./vendor/bin/phpunit test/compliance/EnumVMTest.php --filter enum_cases — OK (4/4)
• ./vendor/bin/phpunit test/unit/VmEnumBasicTest.php --filter testEnumCasesIdentity — OK
• php script/check-selfhost-spine-coverage-sync.php — OK

Changes

• VM SSOT: EnumSupport::casesList() (+ materializeCaseForCasesList())
• JIT: EnumCasesJitHelper compiled via JitVmHelperLink / EnumCasesRuntime
• EnumCasesHelper uses HashTableHelper::packVariables() instead of inline per-case HashTable stores