php-in-php: JIT EvalHelper — route eval() LLVM through VmEval PHP not inline compile path (#1492)

[PurHur]

Category

php-in-php · language

Problem

eval() JIT lowering in lib/JIT/EvalHelper.php (~69 LOC) inlines compile-time literal eval via IncludeHelper::compileInlinedBlock and falls back to VmEval for dynamic strings. Mixed LLVM/inline paths duplicate ext/standard/VmEval.php semantics (#4652).

Goal: single PHP SSOT for eval return value, scope, and error handling — thin JIT trampoline only.

php-src reference

• php/php-src ext/standard/basic_functions.c — zif_eval, zend_eval_stringl
• php/php-src Zend/zend_execute.c — eval scope flags

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php bin/vm.php -r "var_export(eval(\"return 1+2;\"));" 2>&1
php bin/jit.php -r "var_export(eval(\"return 1+2;\"));" 2>&1
php bin/jit.php -r "\$code=\"return 3;\"; var_export(eval(\$code));" 2>&1
wc -l lib/JIT/EvalHelper.php ext/standard/VmEval.php
'

Scope (PHP-in-PHP)

Path	Work
lib/JIT/EvalHelper.php	Always delegate to VmEval / runtime eval entry
ext/standard/VmEval.php	Own literal + dynamic eval; return false + exception parity
lib/JIT/IncludeHelper.php	Remove eval-specific inline block shortcut when PHP path handles literals

Done when

• Literal and dynamic eval() match VM/Zend on repro
• EvalHelper.php ≤ ~30 LOC; no separate literal inline LLVM path
• ./script/ci-fast.sh --filter Eval green (Language: eval() — JIT/AOT lowering in caller scope (phase 2 of #4410 / #3358) #4652 compliance)

Related

• Language: eval() — JIT/AOT lowering in caller scope (phase 2 of #4410 / #3358) #4652 · php-in-php: JIT IncludeHelper — route include/require LLVM through VmInclude PHP not ~1k-line monolith (#1492) #10063 IncludeHelper · Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492

[PurHur]

claim: cursor-agent-lane-a — starting this run

[PurHur]

Merged via #10648.

Verification:

• eval_dynamic_fn.phpt green on VM + JIT (dynamic $code in user function)
• EvalBuiltinTest + EvalJitTest — OK (10 tests)
• EvalHelper.php slimmed to 27 LOC; parse SSOT in VmEval::tryCompileBlock()