Repository navigation
Stdlib: number_format() dec_point: named parameter — unknown name must Error not silently use defaults (ext/standard/number_format.c) #10132
Description
Category
stdlib · php-src-strict
Problem
number_format() accepts the wrong named parameter dec_point: (php-src stub uses decimal_separator:). Zend throws Error: Unknown named parameter $dec_point. This compiler binds by position/slot and formats with default separators, masking caller bugs.
php-src reference
- php/php-src
ext/standard/number_format.c—PHP_FUNCTION(number_format) - php/php-src
ext/standard/basic_functions.stub.php— parameter namesdecimal_separator,thousands_separator
Repro (failure today)
test/repro/issue_number_format_dec_point_named.php:
<?php
echo number_format(1234.5, 2, dec_point: ',', thousands_sep: '.'), "\n";./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php8.2 test/repro/issue_number_format_dec_point_named.php
php bin/vm.php test/repro/issue_number_format_dec_point_named.php
'| Runtime | Result |
|---|---|
| Zend PHP 8.0+ | Fatal Error: Unknown named parameter $dec_point |
| VM today | 1.234,50 (wrong — dec_point ignored, defaults used) |
Positive control (after fix):
echo number_format(1234.5, 2, decimal_separator: ',', thousands_separator: '.'), "\n";
// both engines: 1.234,50Scope (PHP-in-PHP)
| Path | Work |
|---|---|
ext/standard/number_format.php |
register stub parameter names for named-arg validation |
lib/Compiler.php / call lowering |
reject unknown named parameters at compile (preferred) or runtime |
| Tests | test/compliance/cases/stdlib/number_format_named_params.phpt |
Done when (php-src-strict)
- Repro fatals with
Unknown named parameter $dec_pointon VM -
decimal_separator:/thousands_separator:named calls match Zend output - Positional 4-arg form unchanged
-
./script/ci-fast.sh --filter number_format_namedgreen
Related
- Stdlib: number_format() thousands_separator int — must TypeError not compiler LogicException (ext/standard/number_format.c) #7443 separator coercion · Stdlib: compact() with @ on undefined variable returns NULL not [] (ext/standard/basic_functions.c) #10096 compact @ · named-arg compile rejects · Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492
Activity
PurHur commentedon Jun 19, 2026
claim: PHP Compiler STD Lib — starting this run
Reject number_format() dec_point:/thousands_sep: named aliases (#10132)…
PurHur commentedon Jun 19, 2026
Merged via #10138.
Fix: Removed incorrect
dec_point/thousands_sepnamed-parameter aliases fromBuiltinParamNames::aliasesForFunction(). Wrong names now throwError: Unknown named parameter $dec_pointmatching Zend; canonicaldecimal_separator:/thousands_separator:unchanged.Verification:
php bin/vm.php test/repro/issue_number_format_dec_point_named.php→ Fatal Error (matches php8.2)php bin/vm.php test/repro/issue_number_format_named.php→'1.23'/'1 235'vendor/bin/phpunit --filter number_format_dec_point_named→ OK (4)php bin/compile.php -lon both repros → exit 0