fix: move adding arithmetic resources from preprocessing to compilation - #190
Merged
Conversation
Brendan-Reid1991
approved these changes
Apr 28, 2025
Brendan-Reid1991
left a comment
Brendan-Reid1991
left a comment
Contributor
There was a problem hiding this comment.
Nice! no major changes apart from docstrings
| This step generates such resources for the parent. | ||
|
|
||
| Args: | ||
| routine: routine to be preprocessed |
Contributor
There was a problem hiding this comment.
First input has changed to resources, similarly with the Returns section below, looks like a simple case of docstring getting out of sync with functionality!
Brendan-Reid1991
pushed a commit
that referenced
this pull request
May 21, 2025
…on (#190) * fix: move adding arithmetic resources from preprocessing to compilation * docs: update docstrings * test: increase the timeout for a long test
Brendan-Reid1991
pushed a commit
that referenced
this pull request
May 21, 2025
…on (#190) * fix: move adding arithmetic resources from preprocessing to compilation * docs: update docstrings * test: increase the timeout for a long test
Brendan-Reid1991
pushed a commit
that referenced
this pull request
May 21, 2025
…on (#190) * fix: move adding arithmetic resources from preprocessing to compilation * docs: update docstrings * test: increase the timeout for a long test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where additive/multiplicative resources added as
derived_resourceswould not count towards the sum/product for the parent.It achieves it by moving the logic of the preprocessing step into the compilation logic.
Please verify that you have completed the following steps