Fix letterSpacing using GuiProp.FontSize instead of GuiProp.LetterSpacing#16
Merged
michaelsakharov merged 1 commit intoSep 21, 2025
Conversation
Contributor
|
Yeah this is a typo, its specifically when you move your cursor outside the element it needs to scroll, it wasent previously using the correct value for determining the cursor position during that process |
Contributor
Author
|
I'm fixing this as part of my UI scaling PR |
Contributor
Author
|
Reopening since we're not merging the current UI scaling PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looked a bit suspicious when I first saw it, but after some poking around, I still don't know how
letterSpacingactually affects the resulting cursor position. The result seems correct regardless of whatletterSpacingvalue I use.I'm opening this PR as a way to track this issue since I don't know if this actually fixes anything.