Skip to content

[replay 7239] fix(memory): characters joining a merged group chat no longer hide earlier memories - #483

Open
Promansis wants to merge 3 commits into
replay-base/7239-cleanfrom
replay/7239-gfs5
Open

Promansis wants to merge 3 commits into
replay-base/7239-cleanfrom
replay/7239-gfs5

Conversation

@Promansis

Copy link
Copy Markdown
Owner

Dottore replay shadow (fork only) of upstream PR 7239 at accf679, the first head CodeRabbit reviewed.

Original title: fix(memory): characters joining a merged group chat no longer hide earlier memories

SpicyMarinara and others added 3 commits October 7, 2026 12:54
…rlier memories

In merged Roleplay group chats the recall audience is every chat
character, and a scene was recalled only when all of them had been there.
After a character joined, no earlier scene qualified. Character-scoped
Chat Summaries were also rendered as whichever character's random id
sorted first, which could be the newcomer, so they rendered empty.

A merged reply can voice any character, so recall now keeps what any
present character remembers and marks what not everyone knows:
"Scene summary (known only to Alice):" for scenes and
"[Known only to Alice: ...]" for private summary sections. Memories no
present character has, including narrator-only scenes, stay out.
Individual group chats, single-reader recall, impersonation and narrator
rules are unchanged.

Closes Pasta-Devs#7237

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Keeps every CHANGELOG entry from both sides.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🎭 Dottore Review — Concluded

Tip

Review posted. The specimen has left the observation table.

@github-actions

Copy link
Copy Markdown

🎭 Dottore Review

Dottore Verdict: Specimen Unexamined

Caution

REVIEW INCOMPLETE
Dottore Review did not complete, so no model findings are available.

Findings Nitpicks Controls Reviewed Head Mode
0 0 1 fail 38d39088 full

Note

Mode: full
Head: 38d3908 - replay replay/7239-gfs5 at accf679 (same tree)
Base: c2f214a - Merge pull request Pasta-Devs#7236 from Pasta-Devs/feat/advanced-memory-fix-all

🧭 Specimen Summary

  • Dottore Review could not complete: TimeoutError: the reply was still streaming after 600s, with 0 thinking, 89 text and 0 tool-input characters streamed, the last at 616s

🔎 Isolated Defects

Caution

No model findings are available because Dottore Review failed before completing inspection.

🧹 Minor Imperfections

  • None recorded.

✅ Control Checks

Status Type Check Detail
❌ FAIL Review Limitation Review Failed Dottore Review could not complete: TimeoutError: the reply was still streaming after 600s, with 0 thinking, 89 text and 0 tool-input characters streamed, the last at 616s

🧪 Observations

  • No model pass ran; the specimen remained unexamined.

@Promansis

Copy link
Copy Markdown
Owner Author

/dottore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants