[Promansis]

Dottore replay shadow (fork only) of upstream PR 7265 at ebb2187, the first head CodeRabbit reviewed.

Original title: fix(memory): give the visibility decision the scene and recent messages so present characters keep seeing replies

[github-actions]

🎭 Dottore Review — Concluded

Tip

Review posted. The specimen has left the observation table.

• Commit: ebb2187 - fix(memory): hide new messages only when the Decision model is sure the character is away

[github-actions]

🎭 Dottore Review

Dottore Verdict: Viable, With Notes

Warning

VIABLE, WITH NOTES
No actionable defects were isolated, but non-blocking notes remain.

Findings	Nitpicks	Controls	Reviewed Head	Mode
0	1	1 unknown	ebb2187e	full

Note

Mode: full
Head: ebb2187 - fix(memory): hide new messages only when the Decision model is sure the character is away
Base: 6c9c372 - Merge pull request Pasta-Devs#7262 from Pasta-Devs/fix/extension-watchdog-background-7260

🧭 Specimen Summary

• The specimen reverses the Decision question from evidence of presence to evidence of exclusion, and reverses the score comparison with it; uncertainty is intended to preserve visibility rather than manufacture absence. It also supplies the speaker explicitly, draws several preceding messages across scene boundaries, and gives the Helper prompt the same conservative rule.

🔎 Isolated Defects

Tip

No actionable defects isolated.

🧹 Minor Imperfections

Location	Nitpick
docs/agents/memory.md:135 (RIGHT)	Qualify the promised minimum context

✅ Control Checks

Status	Type	Check	Detail
⚠️ UNKNOWN	Proof Gap	Visibility regression evidence	Focused proof should distinguish below-threshold, threshold-equal, and above-threshold exclusion scores in standalone and shared scene-check requests, and exercise new-scene context under token pressure.

🧪 Observations

• Finder: Traced the inverted presence question through score validation, bounded batches, both hiddenFromScores callers, and persisted message/swipe visibility; the producer and consumers agree on the new polarity.
• Finder: Followed prior-message selection through empty history, scene boundaries, the four-message target, the twelve-message cap, and token trimming; the minimum is a selection preference, not a surviving prompt guarantee.
• Finder: Checked author and narrator exemptions, manual-visibility protection, and the final candidate filter before persistence; the changed decisions retain those boundaries.

📝 Lab Notes

• Dottore examined 0 candidate(s) against the code: 0 confirmed, 0 rejected, 0 unresolved.