Skip to content

[replay 7288] fix(trackers): use manual Tracker Panel edits as the base for the next generation - #460

Open
Promansis wants to merge 2 commits into
replay-base/7288from
replay/7288-gab
Open

Promansis wants to merge 2 commits into
replay-base/7288from
replay/7288-gab

Conversation

@Promansis

Copy link
Copy Markdown
Owner

Dottore replay shadow (fork only) of upstream PR 7288 at 5263dee, the first head CodeRabbit reviewed.

Original title: fix(trackers): use manual Tracker Panel edits as the base for the next generation

SpicyMarinara and others added 2 commits October 8, 2026 02:05
…t generation

A regeneration started from the reply before the regenerated one and
excluded that reply, but a Tracker Panel edit lives only on the edited
reply's own row. Regenerating or swiping the corrected reply therefore
brought back the wrong value the user had just fixed.

- Record every tracker value a manual edit changes (scene text by value,
  lists and playerStats keys by fingerprint) in the existing
  manualOverrides column.
- getForGeneration lays the edits still visible on any swipe of the
  regenerated reply over its base, so the prompt, lorebook scan, tracker
  agents and Peek Prompt start from them. A tracker run that changes the
  value retires the edit.
- Values the trackers leave out keep the edit, the GM tool base keeps it,
  and a regenerated swipe no tracker wrote gets a row with it.
- A tracker run that rewrites its own row keeps that row's edit record.

Closes Pasta-Devs#7286

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…-edit-base

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

🎭 Dottore Review — Concluded

Tip

Review posted. The specimen has left the observation table.

  • Commit: 5263dee - Merge remote-tracking branch 'origin/staging' into fix/tracker-manual-edit-base

@github-actions

Copy link
Copy Markdown

🎭 Dottore Review

Dottore Verdict: Viable, With Notes

Warning

VIABLE, WITH NOTES
No actionable defects were isolated, but non-blocking notes remain.

Findings Nitpicks Controls Reviewed Head Mode
0 0 1 unknown 5263deed full

Note

Mode: full
Head: 5263dee - Merge remote-tracking branch 'origin/staging' into fix/tracker-manual-edit-base
Base: d0dc3dc - Merge pull request Pasta-Devs#7281 from Pasta-Devs/fix/excerpts-privacy-code-followup

🧭 Specimen Summary

  • DOTTORE_LAB_STAGE=asker: the scouts and the asker ran; nothing was judged or published.

🔎 Isolated Defects

Tip

No actionable defects isolated.

🧹 Minor Imperfections

  • None recorded.

✅ Control Checks

Status Type Check Detail
⚠️ UNKNOWN Review Limitation Lab Asker Only DOTTORE_LAB_STAGE=asker: the scouts and the asker ran; nothing was judged or published.

🧪 Observations

  • No model pass ran; the specimen remained unexamined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants