Repository navigation
[replay 7239] fix(memory): characters joining a merged group chat no longer hide earlier memories - #431
Open
Promansis wants to merge 2 commits into
Open
[replay 7239] fix(memory): characters joining a merged group chat no longer hide earlier memories#431Promansis wants to merge 2 commits into
Promansis wants to merge 2 commits into
Conversation
…rlier memories In merged Roleplay group chats the recall audience is every chat character, and a scene was recalled only when all of them had been there. After a character joined, no earlier scene qualified. Character-scoped Chat Summaries were also rendered as whichever character's random id sorted first, which could be the newcomer, so they rendered empty. A merged reply can voice any character, so recall now keeps what any present character remembers and marks what not everyone knows: "Scene summary (known only to Alice):" for scenes and "[Known only to Alice: ...]" for private summary sections. Memories no present character has, including narrator-only scenes, stay out. Individual group chats, single-reader recall, impersonation and narrator rules are unchanged. Closes Pasta-Devs#7237 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Keeps every CHANGELOG entry from both sides. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🎭 Dottore Review — ConcludedTip Review posted. The specimen has left the observation table.
|
🎭 Dottore ReviewDottore Verdict: Viable, With NotesWarning VIABLE, WITH NOTES
Note Mode: 🧭 Specimen Summary
🔎 Isolated DefectsTip No actionable defects isolated. 🧹 Minor Imperfections
✅ Control Checks
🧪 Observations
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dottore replay shadow (fork only) of upstream PR 7239 at accf679, the first head CodeRabbit reviewed.
Original title: fix(memory): characters joining a merged group chat no longer hide earlier memories