This repository was archived by the owner on Oct 6, 2020. It is now read-only.
Open
Conversation
Updating to the Angular 8
shane-chen
approved these changes
Jul 10, 2019
chintans
approved these changes
Oct 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug, feature request, or proposal:
Refactor any references to DOCUMENT in order to comply with Angular 8 changes
ERROR in ./node_modules/md2/core/common-behaviors/common-module.js 64:46-54
"export 'DOCUMENT' was not found in '@angular/platform-browser'
Compatibility with Angular 8
Which versions of Angular, MD2, OS, browsers are affected?
Angular 8, MD2 0.33
Is there anything else we should know?
DOCUMENT is removed from @angular/platform-browser If you use DOCUMENT from @angular/platform-browser, you should start to import this from @angular/common.
This change is