Repository navigation
ci verification for pingdotgg/t3code#11438 - #3
Project516 wants to merge 1 commit into
Conversation
Blacksmith runner labels only resolve for the pingdotgg org, so every job in CI, the mobile fingerprint check, and the Windows test lane queues forever on a fork. Pick the runner with case() on the repository owner so forks get the equivalent GitHub-hosted runner from the same workflow file.
github-actions
Bot
added
vouch:trusted
![project516-review-bot[bot]](https://avatars.githubusercontent.com/in/4903871?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR updates three workflow files to use GitHub-hosted runners for forks and Blacksmith runners for the pingdotgg org. However, the case() function used in the runs-on expressions does not exist in GitHub Actions expression syntax. All workflows using this pattern will fail with an unrecognized function error. Additionally, the fallback runner labels macos-26 and windows-2025 do not correspond to existing GitHub-hosted runner images.
review-bot, model nvidia/nemotron-3-ultra-550b-a55b:free, verdict request_changes
| lint: | ||
| name: Lint | ||
| runs-on: blacksmith-8vcpu-ubuntu-2404 | ||
| runs-on: ${{ case(github.repository_owner == 'pingdotgg', 'blacksmith-8vcpu-ubuntu-2404', 'ubuntu-24.04') }} |
There was a problem hiding this comment.
GitHub Actions does not have a case() function. Use the ternary pattern: ${{ github.repository_owner == 'pingdotgg' && 'blacksmith-8vcpu-ubuntu-2404' || 'ubuntu-24.04' }}. This applies to every runs-on line changed in this file (lines 25, 63, 89, 143, 207, 236, 305, 318, 352, 430, 458, 503).
| # output empty, and that must run the lint rather than silently skip it. | ||
| if: ${{ !cancelled() && needs.mobile_native_changes.outputs.changed != 'false' }} | ||
| runs-on: blacksmith-6vcpu-macos-26 | ||
| runs-on: ${{ case(github.repository_owner == 'pingdotgg', 'blacksmith-6vcpu-macos-26', 'macos-26') }} |
There was a problem hiding this comment.
macos-26 is not a valid GitHub-hosted runner label. Current macOS runners are macos-latest, macos-14, macos-13, macos-12. Use macos-14 (or macos-latest) as the fallback.
| fingerprint: | ||
| name: Native fingerprint diff | ||
| runs-on: blacksmith-8vcpu-ubuntu-2404 | ||
| runs-on: ${{ case(github.repository_owner == 'pingdotgg', 'blacksmith-8vcpu-ubuntu-2404', 'ubuntu-24.04') }} |
There was a problem hiding this comment.
Same case() function error. Replace with ternary pattern: ${{ github.repository_owner == 'pingdotgg' && 'blacksmith-8vcpu-ubuntu-2404' || 'ubuntu-24.04' }}.
| test: | ||
| name: Test (${{ inputs.package || 'all non-server' }}) | ||
| runs-on: blacksmith-8vcpu-windows-2025 | ||
| runs-on: ${{ case(github.repository_owner == 'pingdotgg', 'blacksmith-8vcpu-windows-2025', 'windows-2025') }} |
There was a problem hiding this comment.
Two issues: (1) case() function does not exist; use ternary pattern. (2) windows-2025 is not a current GitHub-hosted runner label. Available Windows runners are windows-latest, windows-2022, windows-2019. Use windows-2022 as the fallback.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
1 participant
Throwaway fork-context CI run for pingdotgg#11438. Closed after the run.