Fix missing type annotations#5655
Merged
Merged
Conversation
mypy now runs with 0 issues found. Signed-off-by: Felix Schnabel <f.schnabel@tum.de>
for more information, see https://pre-commit.ci
Signed-off-by: Felix Schnabel <f.schnabel@tum.de>
f-schnabel
force-pushed
the
fix_type_annotations
branch
from
December 5, 2022 14:57
92b5a98 to
f368bd3
Compare
f-schnabel
marked this pull request as ready for review
December 5, 2022 15:03
f-schnabel
marked this pull request as draft
December 5, 2022 15:05
Signed-off-by: Felix Schnabel <f.schnabel@tum.de>
f-schnabel
marked this pull request as ready for review
December 5, 2022 16:12
Contributor
|
/build |
f-schnabel
changed the title
wyli
enabled auto-merge (squash)
December 5, 2022 16:41
wyli
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5605.
Description
Fix missing type annotations so
./runtests.sh --mypynow finds 0 warnings.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.