Skip to content

enhance supported format check (#5634) #5640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wyli merged 1 commit into from
Dec 3, 2022
+5 −3
Merged

enhance supported format check (#5634) #5640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions monai/data/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,8 +1099,8 @@ def is_supported_format(filename: Union[Sequence[PathLike], PathLike], suffixes:
"""
filenames: Sequence[PathLike] = ensure_tuple(filename)
for name in filenames:
tokens: Sequence[str] = PurePath(name).suffixes
if len(tokens) == 0 or all("." + s.lower() not in "".join(tokens) for s in suffixes):
full_suffix = "".join(map(str.lower, PurePath(name).suffixes))
if all(f".{s.lower()}" not in full_suffix for s in suffixes):
return False

return True
Expand Down
4 changes: 3 additions & 1 deletion tests/test_is_supported_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,11 @@

TEST_CASE_6 = [{"filename": "1.3.12.2.1107.5.4.4.145.nii.gz", "suffixes": ["nii.gz"]}, True]

TEST_CASE_7 = [{"filename": "test.PNG", "suffixes": ["bmp", "png"]}, True]


class TestIsSupportedFormat(unittest.TestCase):
@parameterized.expand([TEST_CASE_1, TEST_CASE_2, TEST_CASE_3, TEST_CASE_4, TEST_CASE_5, TEST_CASE_6])
@parameterized.expand([TEST_CASE_1, TEST_CASE_2, TEST_CASE_3, TEST_CASE_4, TEST_CASE_5, TEST_CASE_6, TEST_CASE_7])
def test_value(self, input_param, result):
self.assertEqual(is_supported_format(**input_param), result)

Expand Down