Skip to content

5001 fix convert global weights#5002

Merged
wyli merged 4 commits into
Project-MONAI:devfrom
holgerroth:5001-fix-convert-global-weights
Aug 26, 2022
Merged

5001 fix convert global weights#5002
wyli merged 4 commits into
Project-MONAI:devfrom
holgerroth:5001-fix-convert-global-weights

Conversation

@holgerroth

Copy link
Copy Markdown
Collaborator

Fixes #5001.

Description

Raise error if no weights are converted.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Holger Roth <hroth@nvidia.com>
Signed-off-by: Holger Roth <hroth@nvidia.com>
@holgerroth

Copy link
Copy Markdown
Collaborator Author

/black

Comment thread monai/fl/client/monai_algo.py Outdated
Signed-off-by: Holger Roth <hroth@nvidia.com>

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli

wyli commented Aug 26, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli wyli enabled auto-merge (squash) August 26, 2022 14:51
@wyli wyli merged commit 1aabcbc into Project-MONAI:dev Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No error raised if no global weights are converted in MonaiAlgo

2 participants