Skip to content

Improve MonaiAlgo#4985

Merged
wyli merged 9 commits into
Project-MONAI:devfrom
holgerroth:4982-monai-algo-disable-ckpt-loader
Aug 24, 2022
Merged

Improve MonaiAlgo#4985
wyli merged 9 commits into
Project-MONAI:devfrom
holgerroth:4982-monai-algo-disable-ckpt-loader

Conversation

@holgerroth

@holgerroth holgerroth commented Aug 24, 2022

Copy link
Copy Markdown
Collaborator

Fixes #4982.

Description

Several improvements to MonaiAlgo:

  1. warn if no weights were loaded
  2. disable checkpoint loaders by default if defined in train/evaluate configs
  3. send best checkpoint if requested
  4. allow deterministic training

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Holger Roth <hroth@nvidia.com>
Signed-off-by: Holger Roth <hroth@nvidia.com>
Signed-off-by: Holger Roth <hroth@nvidia.com>
Signed-off-by: Holger Roth <hroth@nvidia.com>
@holgerroth

Copy link
Copy Markdown
Collaborator Author

/black

Comment thread monai/fl/client/monai_algo.py Outdated
Comment thread monai/fl/client/monai_algo.py
Signed-off-by: Holger Roth <hroth@nvidia.com>
Signed-off-by: Holger Roth <hroth@nvidia.com>
Signed-off-by: Holger Roth <hroth@nvidia.com>
Signed-off-by: Holger Roth <hroth@nvidia.com>
@holgerroth holgerroth requested a review from Nic-Ma August 24, 2022 17:36
@holgerroth

Copy link
Copy Markdown
Collaborator Author

/black

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli enabled auto-merge (squash) August 24, 2022 18:33
@wyli

wyli commented Aug 24, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli wyli merged commit aa93129 into Project-MONAI:dev Aug 24, 2022

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks for the update.

wojiazaiyugang pushed a commit to wojiazaiyugang/MONAI that referenced this pull request Aug 25, 2022
Signed-off-by: Holger Roth <hroth@nvidia.com>
Signed-off-by: wojiazaiyugang <wojiazaiyugang@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve MonaiAlgo: weight loading warning, disable ckpt loaders, support sending best model, determinism

3 participants