Skip to content

4856 resampling cupy backend for cuda-based spline interpolation#4919

Merged
wyli merged 18 commits into
Project-MONAI:devfrom
wyli:map-coord
Aug 19, 2022
Merged

4856 resampling cupy backend for cuda-based spline interpolation#4919
wyli merged 18 commits into
Project-MONAI:devfrom
wyli:map-coord

Conversation

@wyli

@wyli wyli commented Aug 16, 2022

Copy link
Copy Markdown
Contributor

Fixes #4856

Description

when the interpolation mode is an integer,

  • scipy.ndimage resampling (cpu tensor) or
  • cupyx.scipy.ndimage resampling (cuda tensor)

will be used given that they are optionally imported.
these bring in spline interpolation with order 0-5.

Status

ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 3 commits August 16, 2022 23:13
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added 3 commits August 17, 2022 09:36
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Aug 17, 2022

Copy link
Copy Markdown
Contributor Author

/build

wyli added 2 commits August 17, 2022 15:31
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from Nic-Ma, ericspod, rijobro and yiheng-wang-nv and removed request for rijobro and yiheng-wang-nv August 17, 2022 19:08
@wyli

wyli commented Aug 17, 2022

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli marked this pull request as ready for review August 17, 2022 19:09
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
prefer numpy backend for integer interp mode

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Aug 18, 2022

Copy link
Copy Markdown
Contributor Author

/build

1 similar comment
@wyli

wyli commented Aug 18, 2022

Copy link
Copy Markdown
Contributor Author

/build

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Aug 18, 2022

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement, seems like non-breaking change.

Comment thread monai/utils/enums.py
wyli and others added 3 commits August 19, 2022 10:15
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Aug 19, 2022

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli enabled auto-merge (squash) August 19, 2022 09:23
@wyli wyli merged commit 009af55 into Project-MONAI:dev Aug 19, 2022
@wyli wyli deleted the map-coord branch August 19, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

optional cupy/cucim backend for spatial resampling

2 participants