Skip to content

4910 Add the mean iou handler#4916

Merged
wyli merged 6 commits into
Project-MONAI:devfrom
binliunls:4910-meaniou-handler
Aug 16, 2022
Merged

4910 Add the mean iou handler#4916
wyli merged 6 commits into
Project-MONAI:devfrom
binliunls:4910-meaniou-handler

Conversation

@binliunls

@binliunls binliunls commented Aug 16, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: binliu binliu@nvidia.com

Fixes #4910 .

Description

The IoU metric "MeanIoU" lacks a corresponding handler, which will lead to inconvinience when using this metric in ignite engine as key_metric. Therefore, I'd like to add a handler of IoU metric named "MeanIoUHandler" to fix this problem.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls binliunls requested a review from Nic-Ma August 16, 2022 14:13
@binliunls binliunls changed the title [WIP] 4910 Add the mean iou handler 4910 Add the mean iou handler Aug 16, 2022
@binliunls binliunls marked this pull request as ready for review August 16, 2022 14:47
@binliunls binliunls requested a review from wyli August 16, 2022 14:49
@Nic-Ma

Nic-Ma commented Aug 16, 2022

Copy link
Copy Markdown
Contributor

/black

@Nic-Ma

Nic-Ma commented Aug 16, 2022

Copy link
Copy Markdown
Contributor

/build

Comment thread tests/test_handler_mean_iou.py Outdated

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.
Looks good to me now.

@Nic-Ma

Nic-Ma commented Aug 16, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli wyli merged commit fb976d7 into Project-MONAI:dev Aug 16, 2022
@binliunls binliunls deleted the 4910-meaniou-handler branch October 21, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the class name of the IoU metric consistent with other metrics

3 participants