Skip to content

4354 workaround protobuf issue#4355

Merged
Nic-Ma merged 8 commits into
Project-MONAI:devfrom
wyli:workaround-protobuf-error
May 26, 2022
Merged

4354 workaround protobuf issue#4355
Nic-Ma merged 8 commits into
Project-MONAI:devfrom
wyli:workaround-protobuf-error

Conversation

@wyli

@wyli wyli commented May 26, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Wenqi Li wenqil@nvidia.com

part of #4354

Description

workaround as suggested

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli changed the title 4353 workaround protobuf issue 4354 workaround protobuf issue May 26, 2022
@wyli wyli marked this pull request as ready for review May 26, 2022 08:16
@wyli wyli requested review from Nic-Ma and yiheng-wang-nv May 26, 2022 08:17
@wyli wyli force-pushed the workaround-protobuf-error branch from 88f49e5 to 62581f7 Compare May 26, 2022 08:53
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the workaround-protobuf-error branch from 62581f7 to 08f9296 Compare May 26, 2022 09:02
Comment thread runtests.sh Outdated
wyli and others added 3 commits May 26, 2022 10:35
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented May 26, 2022

Copy link
Copy Markdown
Contributor

/build

wyli and others added 2 commits May 26, 2022 11:46
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@wyli

wyli commented May 26, 2022

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma force-pushed the workaround-protobuf-error branch from 9336b93 to 8358d82 Compare May 26, 2022 11:23
@Nic-Ma

Nic-Ma commented May 26, 2022

Copy link
Copy Markdown
Contributor

/build

1 similar comment
@Nic-Ma

Nic-Ma commented May 26, 2022

Copy link
Copy Markdown
Contributor

/build

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@Nic-Ma

Nic-Ma commented May 26, 2022

Copy link
Copy Markdown
Contributor

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) May 26, 2022 11:45
@Nic-Ma Nic-Ma mentioned this pull request May 26, 2022
7 tasks
@Nic-Ma Nic-Ma merged commit 29c6219 into Project-MONAI:dev May 26, 2022
@wyli wyli deleted the workaround-protobuf-error branch May 26, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants