Skip to content

3672 Add more messages for AUC warning#3676

Merged
Nic-Ma merged 10 commits into
Project-MONAI:devfrom
Nic-Ma:3672-change-auc-warning
Jan 19, 2022
Merged

3672 Add more messages for AUC warning#3676
Nic-Ma merged 10 commits into
Project-MONAI:devfrom
Nic-Ma:3672-change-auc-warning

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

Fixes #3672 .

Description

This PR enhanced the warning messages according to @ericspod 's comment #3672 (comment).

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Jan 18, 2022

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Jan 18, 2022

Copy link
Copy Markdown
Contributor Author

/build

Comment thread monai/metrics/rocauc.py Outdated
@Nic-Ma

Nic-Ma commented Jan 19, 2022

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Jan 19, 2022

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma merged commit b4f8ff1 into Project-MONAI:dev Jan 19, 2022
wyli pushed a commit that referenced this pull request Jan 21, 2022
* [DLMED] change to warning

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add more error message

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] simplify the messages

Signed-off-by: Nic Ma <nma@nvidia.com>
wyli pushed a commit that referenced this pull request Jan 21, 2022
* [DLMED] change to warning

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add more error message

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] simplify the messages

Signed-off-by: Nic Ma <nma@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change exception to warning in AUC metric

3 participants