Skip to content

3654 remove some flake8 errors ignore #3659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wyli merged 2 commits into from
Jan 14, 2022
+5 −14
Merged

3654 remove some flake8 errors ignore #3659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93f6f4d
ignore some flake8 errors
wyli Jan 13, 2022
a8fbc70
fixes #3660 2003->2106
wyli Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cron.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
cron-gpu:
if: github.repository == 'Project-MONAI/MONAI'
container:
image: nvcr.io/nvidia/pytorch:20.03-py3 # CUDA 10.2
image: nvcr.io/nvidia/pytorch:21.06-py3 # CUDA 11.3
options: "--gpus all"
runs-on: [self-hosted, linux, x64, common]
strategy:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/setupapp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
coverage-py3:
if: github.repository == 'Project-MONAI/MONAI'
container:
image: nvcr.io/nvidia/pytorch:20.03-py3 # CUDA 10.2
image: nvcr.io/nvidia/pytorch:21.06-py3 # CUDA 11.3
options: --gpus all
runs-on: [self-hosted, linux, x64, common]
steps:
Expand Down
9 changes: 0 additions & 9 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,20 +100,11 @@ max_line_length = 120
# E501 is not flexible enough, we're using B950 instead
ignore =
E203
E305
E402
E501
E721
E741
F821
F841
F999
W503
W504
C408
E302
W291
E303
N812 # lowercase 'torch.nn.functional' imported as non lowercase 'F'
per_file_ignores = __init__.py: F401
exclude = *.pyi,.git,.eggs,monai/_version.py,versioneer.py,venv,.venv,_version.py
Expand Down
2 changes: 1 addition & 1 deletion tests/test_adaptors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def test_function_signature(self):
def foo(image, label=None, *a, **kw):
pass

f = FunctionSignature(foo)
_ = FunctionSignature(foo)

def test_single_in_single_out(self):
def foo(image):
Expand Down
2 changes: 1 addition & 1 deletion tests/test_simulatedelay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class TestSimulateDelay(NumpyImageTestCase2D):
def test_value(self, delay_test_time: float):
resize = SimulateDelay(delay_time=delay_test_time)
start: float = time.time()
result = resize(self.imt[0])
_ = resize(self.imt[0])
stop: float = time.time()
measured_approximate: float = stop - start
np.testing.assert_allclose(delay_test_time, measured_approximate, rtol=0.5)
Expand Down
2 changes: 1 addition & 1 deletion tests/test_unet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def test_ill_input_shape(self):
@parameterized.expand(ILL_CASES)
def test_ill_input_hyper_params(self, input_param):
with self.assertRaises(ValueError):
net = UNet(**input_param)
_ = UNet(**input_param)


if __name__ == "__main__":
Expand Down