Skip to content

3288 Add support to partition Decathlon style datalist#3291

Merged
Nic-Ma merged 13 commits into
Project-MONAI:devfrom
Nic-Ma:3288-partition-datalist
Nov 10, 2021
Merged

3288 Add support to partition Decathlon style datalist#3291
Nic-Ma merged 13 commits into
Project-MONAI:devfrom
Nic-Ma:3288-partition-datalist

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

Fixes #3288 .

Description

This PR added utility API to create & save train / val datalist from Decathlon style datalist based on cross validation.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Nov 8, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Nov 8, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli November 8, 2021 23:04
Comment thread monai/data/decathlon_datalist.py
@Nic-Ma

Nic-Ma commented Nov 10, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Nov 10, 2021

Copy link
Copy Markdown
Contributor Author

/build

Comment thread monai/data/decathlon_datalist.py Outdated
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma force-pushed the 3288-partition-datalist branch from 2b1d6ef to 3af4eb7 Compare November 10, 2021 07:24
@Nic-Ma

Nic-Ma commented Nov 10, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Nov 10, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma requested a review from wyli November 10, 2021 07:30
Comment thread tests/test_create_cross_validation_datalist.py Outdated
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Nov 10, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Nov 10, 2021

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@Nic-Ma Nic-Ma enabled auto-merge (squash) November 10, 2021 11:31
@Nic-Ma

Nic-Ma commented Nov 10, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma merged commit 64a3db5 into Project-MONAI:dev Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support to create train / val datalists for Decathlon dataset

3 participants