Skip to content

2231 adds backend for largest cc#3239

Merged
wyli merged 3 commits into
Project-MONAI:devfrom
wyli:backend-keeplargecomponent
Nov 3, 2021
Merged

2231 adds backend for largest cc#3239
wyli merged 3 commits into
Project-MONAI:devfrom
wyli:backend-keeplargecomponent

Conversation

@wyli

@wyli wyli commented Nov 2, 2021

Copy link
Copy Markdown
Contributor

Signed-off-by: Wenqi Li wenqil@nvidia.com

part of #2231

Description

adds a backend for keeplargestconnectedcomponent

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli force-pushed the backend-keeplargecomponent branch from 417aa6e to 1aac0c8 Compare November 2, 2021 14:03
@wyli

wyli commented Nov 2, 2021

Copy link
Copy Markdown
Contributor Author

/integration-test

@wyli

wyli commented Nov 2, 2021

Copy link
Copy Markdown
Contributor Author

/black

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the backend-keeplargecomponent branch from 1aac0c8 to 51028f1 Compare November 2, 2021 14:14
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review November 2, 2021 16:54
@wyli

wyli commented Nov 2, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement.
Looks good to me.

@wyli

wyli commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli enabled auto-merge (squash) November 3, 2021 09:23
@wyli wyli merged commit 547830b into Project-MONAI:dev Nov 3, 2021
@wyli wyli deleted the backend-keeplargecomponent branch November 3, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants