Fix 3 issues in CSVIterableDataset#3226
Merged
Merged
Conversation
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
Nic-Ma
commented
Oct 31, 2021
Signed-off-by: Nic Ma <nma@nvidia.com>
Nic-Ma
changed the title
Contributor
Author
|
/black |
Contributor
Author
|
/build |
Merged
1 task
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/build |
Signed-off-by: Nic Ma <nma@nvidia.com>
for more information, see https://pre-commit.ci
Contributor
Author
|
/black |
Contributor
Author
|
/build |
Contributor
Author
|
/build |
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
|
/build |
wyli
approved these changes
Nov 1, 2021
wyli
left a comment
wyli
left a comment
Contributor
There was a problem hiding this comment.
Thanks, it looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixed 3 issues in the
CSVIterableDataset:iter, changedreturntoyield fromto fix it.shuffle=False, the output order is inverse.lengthof buffer is changing during pop, so need to compute in runtime.Also added more tests to cover the issues.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.