Skip to content

2824 deprecate self-hosted docker tests#3145

Merged
wyli merged 20 commits into
devfrom
docker-test
Oct 19, 2021
Merged

2824 deprecate self-hosted docker tests#3145
wyli merged 20 commits into
devfrom
docker-test

Conversation

@wyli

@wyli wyli commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

part of #2824

Description

  • sunset self-hosted docker build in .github/workflows/docker.yml (the relevant tests are on blossom)

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 16 commits October 18, 2021 19:47
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from Nic-Ma and madil90 October 18, 2021 21:31
@wyli

wyli commented Oct 18, 2021

Copy link
Copy Markdown
Contributor Author

@wyli

wyli commented Oct 18, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma

Nic-Ma commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

Hi @wyli ,

I saw the CI tests of dev branch is broken with postmerge test error, does this PR fix it?

Thanks.

wyli added 2 commits October 19, 2021 08:37
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Oct 19, 2021

Copy link
Copy Markdown
Contributor Author

Hi @wyli ,

I saw the CI tests of dev branch is broken with postmerge test error, does this PR fix it?

Thanks.

it looks like weight downloading errors, I tried to fix it here 11f56b4

now I'm adding more commits 8073b73

@wyli

wyli commented Oct 19, 2021

Copy link
Copy Markdown
Contributor Author

/build

@wyli

wyli commented Oct 19, 2021

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli enabled auto-merge (squash) October 19, 2021 17:21
@wyli

wyli commented Oct 19, 2021

Copy link
Copy Markdown
Contributor Author

/build

1 similar comment
@wyli

wyli commented Oct 19, 2021

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli disabled auto-merge October 19, 2021 18:54
@wyli wyli enabled auto-merge (squash) October 19, 2021 18:56
@wyli wyli merged commit dfcfa9a into dev Oct 19, 2021
@wyli wyli deleted the docker-test branch October 19, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants