Skip to content

3082 Enhance heavy random computation of transforms#3086

Merged
wyli merged 10 commits into
Project-MONAI:devfrom
Nic-Ma:3082-enhance-random
Oct 8, 2021
Merged

3082 Enhance heavy random computation of transforms#3086
wyli merged 10 commits into
Project-MONAI:devfrom
Nic-Ma:3082-enhance-random

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Oct 8, 2021

Copy link
Copy Markdown
Contributor

Fixes #3082 .

Description

This PR enhanced the random computation of transforms to avoid heavy computation if not necessary.
And fixed a typo in the type-hint.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Oct 8, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli October 8, 2021 10:14
Comment thread monai/transforms/intensity/array.py Outdated
@wyli

wyli commented Oct 8, 2021

Copy link
Copy Markdown
Contributor

/build

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli merged commit 484bb5c into Project-MONAI:dev Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid heavy random computation if _do_transform=False

2 participants