[vitormattos]

Summary

Adds helper methods to compute rectangle width and height directly from rectangle coordinates.

Usage

$document = (new PdfParser())->parseFile('sampleFile.pdf');

foreach ($document->getPages() as $page) {
    $rectangle = $page->getCropBox() ?? $page->getMediaBox();
    $width = $rectangle?->getWidth();
    $height = $rectangle?->getHeight();
}

[vitormattos]

@PrinsFrank ready for review.

[PrinsFrank]

Hey, thanks for the PR and the effort you've put into this!

I think the implementation is a bit too focussed on a specific use case, but we can get this to be generic! It looks like your end goal is to get the crop box of a page, and if it doesn't exist to get the mediabox.

In the end, the code here mostly boils down to three things:

• Traverse parents for inheritable keys
• Resolve values for references by retrieving the referenced object and resolving their type.
• Retrieving width/height for Rectangles

All three are now implemented with a specific use case in mind, but are patterns that could be reused when we implement them according to spec. I think both would be great additions to this library, solving these problems generically, and all three would qualify for their own PRs.

Thanks again for the PR, and seeing the way you implemented this uncovered some great insights!

What do you think?

[vitormattos]

I refactored the PR to make those parts generic rather than page-specific:

• Parent traversal for inheritable keys now lives in Dictionary (with explicit inheritable-key metadata in DictionaryKey).
• Reference resolution is handled generically in Dictionary.
• Width/height logic is centralized in Rectangle (getWidth() / getHeight()).

Page-level code now only consumes dictionary-level APIs for the CropBox/MediaBox fallback flow.

I also moved the dimension tests to align with your testing feedback.

If you prefer, these changes could be split into smaller PRs. Since this PR was already open and under review, I focused the changes on addressing your comments with the smallest coherent end-to-end update. If you prefer, I can split follow-up refinements into separate PRs after this one.

[vitormattos]

I also changed the PR description after the review.

[PrinsFrank]

Hi,

I only have a few hours per evening to work on this library. Looking at this PR, I think it warrants some rearchitecturing of the Dictionary class and how to traverse parent/child dictionaries. I won't be able to answer that question tonight.

Just to get some context: How many files do you have were you need to traverse Dictionaries for Cropboxes/MediaBoxes to get a definitive answer?

[vitormattos]

I only have a few hours per evening to work on this library. Looking at this PR, I think it warrants some rearchitecturing of the Dictionary class and how to traverse parent/child dictionaries. I won't be able to answer that question tonight.

Just to get some context: How many files do you have were you need to traverse Dictionaries for Cropboxes/MediaBoxes to get a definitive answer?

Good question, but after your implementation, rearchitecturing Dictionary is no longer necessary.
Your page-level getInheritableValue() approach is much cleaner, and this PR now simply builds on top of it.
So we don't need to traverse Dictionary for CropBoxes/MediaBoxes anymore, Document::getPagesDimensions() just calls $page->getCropBox() / $page->getMediaBox() directly.
I already made a push rebased with main branch.

[PrinsFrank]

Thank you for the contribution! I'll release a new version including this change soon!