Skip to content

Added sample file for #272 - #273

Merged
PrinsFrank merged 5 commits into
PrinsFrank:mainfrom
k00ni:sample/issue-272
May 24, 2026
Merged

PrinsFrank merged 5 commits into
PrinsFrank:mainfrom
k00ni:sample/issue-272

Conversation

@k00ni

@k00ni k00ni commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Related issue: #272

The contents.yml is mostly empty, feel free to adapt it as you see fit.

@codecov-commenter

codecov-commenter commented Oct 21, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.20%. Comparing base (f5f4c4a) to head (c4118ef).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #273      +/-   ##
============================================
- Coverage     52.32%   52.20%   -0.12%     
- Complexity     1668     1675       +7     
============================================
  Files            98       98              
  Lines          3077     3017      -60     
============================================
- Hits           1610     1575      -35     
+ Misses         1467     1442      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PrinsFrank

Copy link
Copy Markdown
Owner

@k00ni I've implemented a new grouping algorithm that allows a small y offset between text objects to be still considered on the same line, which fixes the parsing of this specific PDF. I've just ran composer update-content to update the content.yml file for this specific sample. Does this parse as expected now? I think so, right?

@PrinsFrank
PrinsFrank merged commit 09756d1 into PrinsFrank:main May 24, 2026
21 checks passed
@PrinsFrank

Copy link
Copy Markdown
Owner

Thank you for the contribution!!!

@k00ni
k00ni deleted the sample/issue-272 branch May 25, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants