Merged
Conversation
AmeenP
approved these changes
Apr 8, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e4d6139. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Testing
Note
Medium Risk
Changes eval preflight behavior by passing custom HTTP timeouts into
InferenceClientand treating timeout failures as warnings, which could allow eval runs to proceed with an invalid/unwarmed model. Risk is limited to CLI UX/flow and is covered by added tests.Overview
Relaxes
prime evalinference preflight by introducing a dedicatedEVAL_PREFLIGHT_TIMEOUTand wiring it through toInferenceClient, rather than using the default client timeout.Model validation and billing-probe preflights now catch
httpx.TimeoutExceptionand continue with a warning instead of crashing/failing the run.Updates tests to stub
InferenceClientconstruction, assert the preflight timeout is passed through, and adds regression coverage for the timeout-continue paths and custom client timeout support.Reviewed by Cursor Bugbot for commit e4d6139. Bugbot is set up for automated code reviews on this repo. Configure here.