Repository navigation
fix(coding-agent): include Bedrock in Node bundle - #860
imMamdouhaboammar wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Confirming this reproduces on the released v0.7.1, not just Relevant to #751, where the missing chunk is still attributed to the I landed on the same diagnosis from the shipped artifact before I found this PR, and confirmed the emitted module only has to satisfy One small thing on |
|
@badlogic this is now the remaining source fix for #751 and the official Homebrew submission tracked in #843. The released CI is currently |
|
Hi, thanks for taking the time to contribute to Prime Agent! Since open sourcing the project, we’ve received far more pull requests than we can responsibly review and validate. Prime Agent runs directly on users’ machines, so we need to be deliberate about which changes we accept and how they are reviewed. Rather than leave a large backlog that we cannot meaningfully work through, we’re closing the current PR queue and moving to a discussion-first contribution process. We have established new contribution guidelines to help us continue iterating on Prime Agent and better manage contributions from the community. Going forward, we won’t review unsolicited pull requests. Instead, please start with a GitHub Discussion. We’ll identify recurring bugs and feature requests, create Issues for work we want to pursue, and invite pull requests from maintainers or vouched contributors when implementation is ready. Please read the full process documented in our contribution guidelines. While we’re closing this backlog, we’re still reviewing it at a high level to identify recurring bugs, useful ideas, and important problems that we should address ourselves. Thanks again for the time you put into this! |
Summary
importNodeOnlyProvider("./x.js")reference points to an asset that was not emittedRoot cause
packages/ai/src/providers/register-builtins.tsloads Bedrock throughimportNodeOnlyProvider("./amazon-bedrock.js"), where the helper callsimport(specifier). Because that import specifier is dynamic from esbuild's perspective, the coding-agent bundle does not emitdist/bundle/amazon-bedrock.jseven though the generated CLI chunk still references it.This is reproducible on current
main: a clean build produced no Bedrock bundle asset while the CLI chunk contained the unresolved./amazon-bedrock.jsreference.Validation
Before the fix, the new integrity check failed with:
After adding the explicit entry:
npm run buildpasseddist/bundle/amazon-bedrock.jswas emitted and imports successfullystreamBedrockandstreamSimpleBedrocknpm run checkpassednpm pack --workspace packages/coding-agent --dry-run --jsonincludesdist/bundle/amazon-bedrock.jsgit diff --checkpassedThis addresses the source-side cause of #751. The already-published v0.7.0 artifact still requires a replacement release or a new release after this lands.
Note
Include Amazon Bedrock provider in coding-agent Node bundle
amazon-bedrockas a second esbuild entry point in bundle.mjs, alongside the existingclientry, so the Bedrock provider is emitted into the bundle output.verifyNodeOnlyProviderAssetspost-build check that scans output.jsfiles forimportNodeOnlyProvidercalls and throws if any referenced asset files are missing.Macroscope summarized 36842d0.